Skip to content

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Sep 10, 2025

Closes #6773

Changelog

New

Changed

Removed

  • Remove support for sx from RelativeTime

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

This component has no sx usage in github-ui and can be safely migrated

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2025

🦋 Changeset detected

Latest commit: 593bc3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 10, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.53 KB (-0.13% 🔽)
packages/react/dist/browser.umd.js 88.67 KB (-0.06% 🔽)

@joshblack joshblack marked this pull request as ready for review September 10, 2025 22:13
@joshblack joshblack requested a review from a team as a code owner September 10, 2025 22:13
@joshblack joshblack requested review from Copilot and francinelucca and removed request for francinelucca September 10, 2025 22:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes support for the sx prop from the RelativeTime component as part of a migration strategy to eliminate styled-components dependencies. The changes include removing sx prop type definitions, updating component creation utilities, and adjusting Storybook configurations.

  • Remove sx prop support from RelativeTime component
  • Refactor component creation utilities to eliminate styled-components dependency
  • Update Storybook controls to exclude sx-related properties

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/styled-react/src/index.tsx Adds RelativeTime wrapper with sx support to maintain backward compatibility in styled-react package
packages/react/src/utils/create-component.ts Removes styled-components and sx dependencies from component creation utility
packages/react/src/RelativeTime/RelativeTime.stories.tsx Updates Storybook controls to exclude sx prop
packages/react/src/RelativeTime/RelativeTime.features.stories.tsx Updates Storybook controls to exclude sx prop
packages/react/src/RelativeTime/RelativeTime.docs.json Removes sx prop from component documentation
.changeset/short-cloths-deny.md Documents the breaking change for version release

@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2639

@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 16, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 22, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 22, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 22, 2025
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 22, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-6827 September 22, 2025 19:15 Abandoned
@francinelucca francinelucca added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit 6843040 Sep 22, 2025
40 of 41 checks passed
@francinelucca francinelucca deleted the 6773-remove-support-for-sx-from-relative-time branch September 22, 2025 19:31
@primer primer bot mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove support for sx from the RelativeTime component

3 participants