-
Notifications
You must be signed in to change notification settings - Fork 639
ProgressBar: Remove sx
#6837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProgressBar: Remove sx
#6837
Conversation
🦋 Changeset detectedLatest commit: 16115b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes sx prop support from the ProgressBar component as part of the ongoing migration away from styled-components. The change involves updating the component implementation to use standard HTML elements instead of the BoxWithFallback wrapper that provided sx functionality.
Key Changes
- Removed
sxprop support fromProgressBarandProgressBar.Itemcomponents - Replaced
BoxWithFallbackwrapper with standardspanelements - Updated type definitions to exclude
SxProp
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/ProgressBar/ProgressBar.tsx | Main implementation changes removing sx support and BoxWithFallback usage |
| packages/styled-react/src/index.tsx | Removed ProgressBar from styled-react package exports |
| packages/styled-react/src/tests/primer-react.browser.test.tsx | Removed sx prop tests for ProgressBar components |
| packages/styled-react/src/tests/snapshots/exports.test.ts.snap | Updated snapshot to reflect removed ProgressBar export |
| .changeset/three-vans-join.md | Added changeset documenting the breaking change |
| ref={forwardRef} | ||
| progress={progress} | ||
| style={{...styles, ...style}} |
Copilot
AI
Sep 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The progress prop is being removed from the span element props but it's still being passed to the component and may cause React warnings about unknown DOM attributes. Consider filtering it out in the destructuring or rest props.
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3012 |
|
🟢 ci completed with status |
Closes https://github.com/github/primer/issues/5841
Removes
sxsupport inProgressBarChangelog
Removed
sxreferences inProgressBarRollout strategy
Testing & Reviewing
Merge checklist