Skip to content

Conversation

@TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Sep 11, 2025

Closes https://github.com/github/primer/issues/5841

Removes sx support in ProgressBar

Changelog

Removed

  • Removes sx references in ProgressBar

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2025

🦋 Changeset detected

Latest commit: 16115b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 11, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.57 KB (+0.17% 🔺)
packages/react/dist/browser.umd.js 89.58 KB (-0.06% 🔽)

@github-actions github-actions bot requested a deployment to storybook-preview-6837 September 11, 2025 14:06 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6837 September 11, 2025 14:16 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6837 September 11, 2025 14:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6837 September 11, 2025 14:33 Inactive
@TylerJDev TylerJDev marked this pull request as ready for review September 11, 2025 15:01
@TylerJDev TylerJDev requested a review from a team as a code owner September 11, 2025 15:01
@TylerJDev TylerJDev requested review from Copilot and hectahertz and removed request for hectahertz September 11, 2025 15:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes sx prop support from the ProgressBar component as part of the ongoing migration away from styled-components. The change involves updating the component implementation to use standard HTML elements instead of the BoxWithFallback wrapper that provided sx functionality.

Key Changes

  • Removed sx prop support from ProgressBar and ProgressBar.Item components
  • Replaced BoxWithFallback wrapper with standard span elements
  • Updated type definitions to exclude SxProp

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/react/src/ProgressBar/ProgressBar.tsx Main implementation changes removing sx support and BoxWithFallback usage
packages/styled-react/src/index.tsx Removed ProgressBar from styled-react package exports
packages/styled-react/src/tests/primer-react.browser.test.tsx Removed sx prop tests for ProgressBar components
packages/styled-react/src/tests/snapshots/exports.test.ts.snap Updated snapshot to reflect removed ProgressBar export
.changeset/three-vans-join.md Added changeset documenting the breaking change

Comment on lines 61 to 62
ref={forwardRef}
progress={progress}
style={{...styles, ...style}}
Copy link

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The progress prop is being removed from the span element props but it's still being passed to the component and may cause React warnings about unknown DOM attributes. Consider filtering it out in the destructuring or rest props.

Copilot uses AI. Check for mistakes.
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Sep 11, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 15, 2025
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 15, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 15, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6837 September 15, 2025 17:02 Inactive
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 15, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 15, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6837 September 15, 2025 19:15 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Sep 15, 2025
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3012

@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Sep 22, 2025
@TylerJDev TylerJDev added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit 134f96e Sep 22, 2025
43 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/remove-sx-from-progressbar branch September 22, 2025 20:24
@primer primer bot mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants