-
Notifications
You must be signed in to change notification settings - Fork 640
Remove Box usage and sx prop from NavList and related components
#6868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 24be459 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the sx prop and Box component usage from NavList and its related components as part of migrating away from the styled-system approach. The changes move styling from JavaScript-based sx props to CSS modules while maintaining backward compatibility through a styled-react wrapper.
Key changes:
- Removed
sxprop support from all NavList components and subcomponents - Replaced Box component usage with native HTML elements
- Migrated inline styles to CSS modules for GroupHeading component
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/styled-react/src/components/NavList.tsx |
Added wrapper components that re-add sx prop support via Box wrapping for backward compatibility |
packages/react/src/NavList/NavList.tsx |
Removed sx prop from all components, replaced Box usage with native HTML elements, migrated GroupHeading styles to CSS modules |
packages/react/src/NavList/NavList.module.css |
Added CSS module styles for GroupHeading link styling |
packages/react/src/NavList/NavList.docs.json |
Removed sx prop documentation from all NavList components |
packages/react/src/ActionList/shared.ts |
Updated ActionList types to support modern polymorphic components |
packages/react/src/ActionList/List.tsx |
Migrated ActionList to use modern polymorphic pattern |
packages/react/src/ActionList/Item.tsx |
Updated ActionList.Item to use modern polymorphic pattern |
|
@mperrotti I linked: #6768 to this issue if that's okay! Seems like it would close it if I'm understanding right |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3267 |
|
🟢 ci completed with status |
|
This PR will pass integration tests with the following changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
…from-listy-components
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
…6868) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Relates to https://github.com/github/primer/issues/5424 and https://github.com/github/primer/issues/5425
Closes #6768
Changelog
New
Changed
sxprop was removed fromNavListand its subcomponentsRemoved
Rollout strategy
Testing & Reviewing
Merge checklist