Skip to content

Conversation

@mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Sep 17, 2025

Relates to https://github.com/github/primer/issues/5424 and https://github.com/github/primer/issues/5425

Closes #6768

Changelog

New

Changed

sx prop was removed from NavList and its subcomponents

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@Copilot Copilot AI review requested due to automatic review settings September 17, 2025 15:10
@mperrotti mperrotti requested a review from a team as a code owner September 17, 2025 15:10
@mperrotti mperrotti requested a review from joshblack September 17, 2025 15:10
@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2025

🦋 Changeset detected

Latest commit: 24be459

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 17, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the sx prop and Box component usage from NavList and its related components as part of migrating away from the styled-system approach. The changes move styling from JavaScript-based sx props to CSS modules while maintaining backward compatibility through a styled-react wrapper.

Key changes:

  • Removed sx prop support from all NavList components and subcomponents
  • Replaced Box component usage with native HTML elements
  • Migrated inline styles to CSS modules for GroupHeading component

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/styled-react/src/components/NavList.tsx Added wrapper components that re-add sx prop support via Box wrapping for backward compatibility
packages/react/src/NavList/NavList.tsx Removed sx prop from all components, replaced Box usage with native HTML elements, migrated GroupHeading styles to CSS modules
packages/react/src/NavList/NavList.module.css Added CSS module styles for GroupHeading link styling
packages/react/src/NavList/NavList.docs.json Removed sx prop documentation from all NavList components
packages/react/src/ActionList/shared.ts Updated ActionList types to support modern polymorphic components
packages/react/src/ActionList/List.tsx Migrated ActionList to use modern polymorphic pattern
packages/react/src/ActionList/Item.tsx Updated ActionList.Item to use modern polymorphic pattern

@github-actions github-actions bot requested a deployment to storybook-preview-6868 September 17, 2025 15:16 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-6868 September 17, 2025 15:24 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-6868 September 17, 2025 15:31 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-6868 September 17, 2025 15:35 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6868 September 17, 2025 15:43 Inactive
@joshblack
Copy link
Member

@mperrotti I linked: #6768 to this issue if that's okay! Seems like it would close it if I'm understanding right

@github-actions github-actions bot temporarily deployed to storybook-preview-6868 September 24, 2025 19:36 Inactive
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3267

@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Sep 25, 2025
@mperrotti
Copy link
Contributor Author

This PR will pass integration tests with the following changes to the ref callback type: https://github.com/github/github-ui/pull/3266

Copy link
Contributor

@hectahertz hectahertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@francinelucca francinelucca added this pull request to the merge queue Sep 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 26, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 26, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@mperrotti mperrotti enabled auto-merge September 26, 2025 22:36
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 26, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 26, 2025
@mperrotti mperrotti added this pull request to the merge queue Sep 26, 2025
Merged via the queue into main with commit 2053cb3 Sep 26, 2025
42 checks passed
@mperrotti mperrotti deleted the mp/rm-box-and-sx-from-listy-components branch September 26, 2025 22:50
@primer primer bot mentioned this pull request Sep 26, 2025
llastflowers pushed a commit that referenced this pull request Sep 29, 2025
…6868)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove support for sx from the NavList component

4 participants