Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
fafe315
remove sx from docs
llastflowers Sep 23, 2025
b232717
remove sx from ActionList/Divider
llastflowers Sep 23, 2025
bcb6574
remove sx from ActionList/Description
llastflowers Sep 23, 2025
edb692c
remove sx from ActionList/Group
llastflowers Sep 23, 2025
243765e
remove sx from ActionList/Item
llastflowers Sep 23, 2025
437dd85
remove boxwithfallback from ActionList/Item and sx from ActionList/Li…
llastflowers Sep 23, 2025
aa52014
remove boxwithfallback from ActionList/List
llastflowers Sep 23, 2025
543f7aa
remove sx from ActionList/Heading
llastflowers Sep 23, 2025
150e0fc
remove sx from ActionList/Visuals and update styled-react exports
llastflowers Sep 24, 2025
75096c7
Create lovely-plums-buy.md
llastflowers Sep 26, 2025
d1719e8
refactor(styled-react): update structure to reduce merge conflicts (#…
joshblack Sep 24, 2025
7dda4a4
Release tracking (rc) (#6892)
primer[bot] Sep 26, 2025
cfb36a4
Bump `primer/primitives` v11.2.0 (#6909)
langermank Sep 26, 2025
0708eb2
Replace bgColor for StateLabel draft with new draft token (#6905)
lukasoppermann Sep 26, 2025
28af9d5
feat(TabNav): remove support for sx prop (#6864)
jonrohan Sep 26, 2025
f7546a5
Add 'prereleased' type to release event triggers (#6912)
jonrohan Sep 26, 2025
e366130
chore(deps-dev): bump tar-fs from 3.1.0 to 3.1.1 (#6907)
dependabot[bot] Sep 26, 2025
46d9d1c
feat(Dialog): remove support for sx (#6812)
joshblack Sep 26, 2025
80635ab
Remove Box usage and `sx` prop from PageLayout (#6872)
mperrotti Sep 26, 2025
a7d59f2
Update FormControl ValidationIcon position (#6908)
llastflowers Sep 26, 2025
72f7f82
Remove Box usage and `sx` prop from Link and misc other areas (storie…
mperrotti Sep 26, 2025
234baa0
Remove Box usage from components (#6805)
mperrotti Sep 26, 2025
1c884fb
Remove Box usage and `sx` prop from NavList and related components (#…
mperrotti Sep 26, 2025
41fea09
chore(deps-dev): bump @vitest/eslint-plugin from 1.3.12 to 1.3.13 in …
dependabot[bot] Sep 29, 2025
82719ab
chore: add test qrapg QL query workflow (#6920)
francinelucca Sep 29, 2025
5091481
re-remove sx and BoxWithFallback from ActionList/Item.tsx
llastflowers Sep 29, 2025
fa08f12
re-remove sx and BoxWithFallback from ActionList/List.tsx
llastflowers Sep 29, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cool-clubs-think.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

Removes Box usage and sx prop from NavList and ActionList
5 changes: 5 additions & 0 deletions .changeset/gold-geckos-send.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

Removes sx prop from PageLayout and subcomponents
5 changes: 5 additions & 0 deletions .changeset/light-schools-wish.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

Removes `Box` component usage and `sx` prop from the `Link` component, Storybook stories, and a .figma.tsx file
5 changes: 5 additions & 0 deletions .changeset/lovely-plums-buy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": major
---

Remove support for styled-components/sx from ActionList component and sub-components
6 changes: 6 additions & 0 deletions .changeset/lucky-wasps-nail.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@primer/react": major
"@primer/styled-react": patch
---

Remove support for `sx` from the `TabNav` component
32 changes: 32 additions & 0 deletions .changeset/pre.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,14 @@
"@primer/styled-react": "0.1.0"
},
"changesets": [
"beige-plums-obey",
"beige-shrimps-sleep",
"better-coins-dream",
"big-oranges-marry",
"bright-dolls-dance",
"bright-parents-flow",
"busy-bananas-smash",
"chilly-dingos-build",
"chubby-colts-nail",
"cold-teams-buy",
"cruel-papers-film",
Expand All @@ -24,46 +28,74 @@
"deprecate-textinputwithtokens",
"dirty-chairs-invent",
"eighty-queens-tap",
"fair-views-laugh",
"few-mails-sing",
"fifty-walls-yawn",
"five-squids-sin",
"fresh-points-cover",
"gentle-rockets-go",
"gentle-sheep-feel",
"giant-impalas-occur",
"gold-dingos-sneeze",
"great-hats-serve",
"hot-bears-cry",
"hot-melons-jump",
"hot-mirrors-feel",
"icy-pianos-say",
"lemon-jokes-camp",
"light-colts-burn",
"little-peas-mix",
"lovely-vans-burn",
"metal-badgers-joke",
"metal-cups-peel",
"metal-deer-refuse",
"metal-lamps-appear",
"mighty-lizards-lick",
"nasty-seals-carry",
"new-dragons-melt",
"new-shrimps-appear",
"nine-cobras-talk",
"orange-taxis-rhyme",
"pretty-women-sing",
"proud-chairs-study",
"rich-walls-fold",
"rotten-carpets-raise",
"rude-cycles-scream",
"salty-geese-own",
"seven-coats-hang",
"seven-forks-join",
"sharp-beans-run",
"sharp-papayas-destroy",
"shiny-deer-lose",
"short-cloths-deny",
"shy-flies-marry",
"silent-wasps-warn",
"silly-parks-give",
"slick-months-cry",
"smooth-singers-thank",
"soft-islands-warn",
"spotty-colts-hear",
"stale-avocados-enjoy",
"stale-wasps-smell",
"strange-knives-study",
"strange-peas-kiss",
"strong-falcons-design",
"strong-lions-tan",
"tame-ducks-ring",
"tasty-cheetahs-pay",
"ten-jobs-attack",
"thin-oranges-lick",
"three-hounds-refuse",
"three-vans-join",
"tricky-eggs-cross",
"twelve-sloths-flow",
"twenty-baboons-pull",
"unlucky-hotels-shake",
"upset-flowers-yawn",
"wet-crews-drum",
"wet-mammals-feel",
"wet-terms-argue",
"wicked-starfishes-shout",
"witty-chicken-leave",
"young-dots-heal",
"young-timers-accept"
Expand Down
5 changes: 5 additions & 0 deletions .changeset/pretty-emus-cover.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

update FormControl ValidationIcon position
5 changes: 5 additions & 0 deletions .changeset/sweet-islands-sleep.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Replace StateLabel color with new draft token
5 changes: 5 additions & 0 deletions .changeset/sweet-results-smell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

Remove support for `sx` from the Dialog component and sub-components
5 changes: 5 additions & 0 deletions .changeset/yummy-years-greet.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

Removes usage of Box component from other components.
80 changes: 80 additions & 0 deletions .github/workflows/graphql-test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
name: Test GraphQL Queries
on:
workflow_dispatch:

jobs:
test-query:
runs-on: ubuntu-latest
steps:
- name: Test GraphQL Query
run: |
echo "Testing GraphQL query against GitHub API..."

# Test query to get repository information
QUERY='query {
repository(owner: "primer", name: "react") {
name
description
stargazerCount
forkCount
defaultBranchRef {
name
}
languages(first: 5) {
nodes {
name
color
}
}
}
}'

# Make the GraphQL API call with detailed error logging
echo "Making GraphQL API call..."
HTTP_STATUS=$(curl -w "%{http_code}" -s -X POST \
-H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
-H "Content-Type: application/json" \
-d "{\"query\": \"$(echo $QUERY | tr '\n' ' ' | sed 's/"/\\"/g')\"}" \
-o response.json \
https://api.github.com/graphql)

RESPONSE=$(cat response.json)

echo "HTTP Status Code: $HTTP_STATUS"
echo "Full GraphQL Response:"
echo "$RESPONSE" | jq '.' || echo "Raw response (invalid JSON): $RESPONSE"

# Check HTTP status first
if [ "$HTTP_STATUS" != "200" ]; then
echo "❌ HTTP request failed with status code: $HTTP_STATUS"
echo "Full response body:"
echo "$RESPONSE"
exit 1
fi

# Check if the response contains GraphQL errors
if echo "$RESPONSE" | jq -e '.errors' > /dev/null 2>&1; then
echo "❌ GraphQL query returned errors:"
echo "$RESPONSE" | jq '.errors'
echo "Full error details:"
echo "$RESPONSE" | jq '.errors[] | {message: .message, type: .type, path: .path, locations: .locations}' || true
exit 1
fi

# Check if the query was successful and has expected data
if echo "$RESPONSE" | jq -e '.data.repository.name' > /dev/null 2>&1; then
echo "✅ GraphQL query executed successfully!"
echo "Repository name: $(echo "$RESPONSE" | jq -r '.data.repository.name')"
echo "Stars: $(echo "$RESPONSE" | jq -r '.data.repository.stargazerCount')"
echo "Default branch: $(echo "$RESPONSE" | jq -r '.data.repository.defaultBranchRef.name')"
else
echo "❌ GraphQL query failed - no valid data returned"
echo "Expected data.repository.name but got:"
echo "$RESPONSE" | jq '.data // "No data field found"'
exit 1
fi

# Cleanup
rm -f response.json
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6 changes: 4 additions & 2 deletions .github/workflows/lock-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ name: Toggle Release Lock

on:
release:
types: [released]
types:
- released
- prereleased
workflow_dispatch:
inputs:
action:
Expand Down Expand Up @@ -78,7 +80,7 @@ jobs:
GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
- name: Update all PRs that are toggled merge when ready
run: |
PR_NUMBERS=$(gh pr list -L 100 -R primer/react --state open --json number,baseRefName,autoMergeRequest,mergeStateStatus,reviewDecision -q '.[] | select(.autoMergeRequest != null) | select(.baseRefName == "main") | select(.mergeStateStatus == "BEHIND") | select(.reviewDecision == "APPROVED") | .number')
PR_NUMBERS=$(gh pr list -L 100 -R primer/react --state open --json number,baseRefName,autoMergeRequest,reviewDecision -q '.[] | select(.autoMergeRequest != null) | select(.baseRefName == "main") | select(.reviewDecision == "APPROVED") | .number')
if [ -n "$PR_NUMBERS" ]; then
echo "Updating $PR_NUMBERS"
echo "$PR_NUMBERS" | xargs -I {} gh pr update-branch -R primer/react {}
Expand Down
12 changes: 0 additions & 12 deletions e2e/components/Dialog.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,6 @@ const stories = [
title: 'Position sidesheet',
id: 'components-dialog-features--side-sheet',
},
{
title: 'Dev: With Css',
id: 'components-dialog-dev--with-css',
},
{
title: 'Dev: With Sx',
id: 'components-dialog-dev--with-sx',
},
{
title: 'Dev: With Sx And Css',
id: 'components-dialog-dev--with-sx-and-css',
},
] as const

test.describe('Dialog', () => {
Expand Down
2 changes: 1 addition & 1 deletion examples/codesandbox/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"@types/react": "^18.3.11",
"@types/react-dom": "^18.3.0",
"@vitejs/plugin-react": "^4.3.3",
"@primer/react": "38.0.0-rc.3",
"@primer/react": "38.0.0-rc.4",
"styled-components": "5.x",
"typescript": "^5.9.2",
"vite": "^7.1.5"
Expand Down
2 changes: 1 addition & 1 deletion examples/nextjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"type-check": "tsc --noEmit"
},
"dependencies": {
"@primer/react": "38.0.0-rc.3",
"@primer/react": "38.0.0-rc.4",
"next": "^15.2.3",
"react": "18.3.1",
"react-dom": "18.3.1",
Expand Down
2 changes: 1 addition & 1 deletion examples/theming/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"dependencies": {
"@primer/octicons-react": "^19.14.0",
"@primer/react": "38.0.0-rc.3",
"@primer/react": "38.0.0-rc.4",
"clsx": "^2.1.1",
"next": "^15.2.3",
"react": "18.3.1",
Expand Down
Loading
Loading