Skip to content

Introduce floating ui api to tooltip #6922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Introduce floating ui api to tooltip #6922

wants to merge 16 commits into from
+162 −107

Conversation

pksjce
Copy link
Contributor

@pksjce pksjce commented Sep 30, 2025

Working on https://github.com/github/primer/issues/5713

  • Install @floating-ui/dom
  • Use method computePosition to replace getAnchorPosition

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 72d709b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-6922 September 30, 2025 06:18 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6922 September 30, 2025 12:35 Inactive
@pksjce pksjce self-assigned this Sep 30, 2025
@pksjce pksjce added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 30, 2025
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 30, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6922 September 30, 2025 13:12 Inactive
@Copilot Copilot AI mentioned this pull request Sep 30, 2025
Closed
@github-actions github-actions bot temporarily deployed to storybook-preview-6922 September 30, 2025 23:53 Inactive
@pksjce pksjce added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 1, 2025
@pksjce
Introduce floating UI API to tooltip
fce9fa0 
Add floating UI API support to tooltip component.
@github-actions github-actions bot requested a deployment to storybook-preview-6922 October 1, 2025 05:18 Abandoned
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 1, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6922 October 1, 2025 05:26 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6922 October 1, 2025 05:34 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6922 October 1, 2025 05:50 Inactive
@pksjce pksjce added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 1, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6922 October 1, 2025 11:54 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 1, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6922 October 1, 2025 12:04 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-6922 October 2, 2025 04:27 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6922 October 2, 2025 04:36 Inactive
@pksjce pksjce added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 2, 2025
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 2, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6922 October 2, 2025 09:32 Inactive
@pksjce pksjce added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 3, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6922 October 3, 2025 07:35 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 3, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6922 October 3, 2025 07:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@pksjce pksjce

Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pksjce