-
Notifications
You must be signed in to change notification settings - Fork 638
chore(TextInput): remove sx #6925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: f5a18ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Removed the 'sx' prop from the TextInput component.
…eact into chore/remove-sx-from-text-input
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/4029 |
🔴 ci completed with status |
Closes https://github.com/github/primer/issues/5828
Current
sx
usage:TextInputWithTokens: 0
TextInput: 60
✅
sx
usages are only in repos other than github-ui; those usages have been added to the tracking issueChangelog
Removed
Remove support for
sx
from theTextInput
,TextInputWithTokens
components, and associated stories, docs, and testsRollout strategy
Testing & Reviewing
Merge checklist