Remove BoxWithFallback usage from VisuallyHidden

[mperrotti]

Relates to https://github.com/github/primer/issues/5424

Since this also removed the sx prop from VisuallyHidden, this PR also includes changes to remove the sx prop from CheckboxOrRadioGroupLabel.

If reviewers prefer I open the CheckboxOrRadioGroupLabel changes in a separate PR, just comment below.

Changelog

New

Changed

Removed

• sx prop has been removed from VisuallyHidden (no sx prop usage found in Primer Query)
• sx prop has been removed from CheckboxGroup.Label and RadioGroup.Label

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: 54dfd4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@primer/react	Major
@primer/styled-react	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Copilot]

Pull Request Overview

This PR removes the BoxWithFallback usage from VisuallyHidden component and eliminates the sx prop from both VisuallyHidden and checkbox/radio group labels as part of modernizing the component architecture.

• Refactors VisuallyHidden to use modern polymorphic props instead of BoxWithFallback
• Removes sx prop support from VisuallyHidden and CheckboxOrRadioGroupLabel
• Updates styled-react package to maintain sx prop support for CheckboxGroup.Label through wrapper components

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
packages/react/src/_VisuallyHidden.tsx	Replaces BoxWithFallback with direct component rendering using modern polymorphic props
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupLabel.tsx	Removes sx prop and SxProp import from the internal label component
packages/styled-react/src/components/CheckboxGroup.tsx	Adds new wrapper component to preserve sx prop support in styled-react package
packages/styled-react/src/index.tsx	Updates exports to use the new CheckboxGroup wrapper component
packages/react/src/CheckboxGroup/CheckboxGroup.tsx	Exports CheckboxGroupProps type
packages/react/src/CheckboxGroup/index.ts	Adds CheckboxGroupProps to exports
packages/react/src/index.ts	Adds CheckboxGroupProps type export
packages/styled-react/src/__tests__/primer-react.browser.test.tsx	Adds test for sx prop support in CheckboxGroup.Label

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

[primer-integration]

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3595

[primer-integration]

🟢 ci completed with status success.