-
Notifications
You must be signed in to change notification settings - Fork 637
chore: cleanup remaining sx props #6959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Mike Perrotti <mperrotti@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 8dbc374 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the remaining sx
prop support from various components as part of the cleanup effort to migrate away from the legacy styled-components system to CSS modules. The changes eliminate SxProp
type annotations, remove BoxWithFallback
dependencies, and update Storybook configuration to exclude the removed props.
Key changes:
- Removed
sx
prop support from internal components and helper utilities - Replaced
BoxWithFallback
usage with native HTML elements in affected components - Updated Storybook controls to exclude the removed
sx
prop from various component stories
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
packages/react/src/utils/story-helpers.tsx | Removed 'sx' from textInputExcludedControlKeys array |
packages/react/src/utils/form-story-helpers.tsx | Removed 'sx' from textInputExcludedControlKeys array |
packages/react/src/internal/components/UnstyledTextInput.tsx | Removed SxProp type and BoxWithFallback, replaced with native input element |
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupValidation.tsx | Removed SxProp type and sx prop usage from component |
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupCaption.tsx | Removed SxProp type and replaced with HTMLSpanElement props |
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx | Removed SxProp, BoxWithFallback usage, and sx prop; replaced with dynamic component selection |
packages/react/src/UnderlineNav/UnderlineNav.stories.tsx | Removed 'sx' from excludedControlKeys array |
packages/react/src/RadioGroup/RadioGroup.stories.tsx | Removed 'sx' from Storybook controls exclude list |
packages/react/src/Radio/Radio.stories.tsx | Removed 'sx' from excludedControlKeys array |
packages/react/src/CheckboxGroup/CheckboxGroup.stories.tsx | Removed 'sx' from Storybook controls exclude list |
packages/react/src/AvatarStack/AvatarStack.tsx | Removed BoxWithFallback dependency and replaced with native span element |
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupCaption.tsx
Outdated
Show resolved
Hide resolved
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
…into chore/cleanup-remaining-sx
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3993 |
🟢 ci completed with status |
Borrowing changes from #6929 that don't have blockers and can be merged now
Relates to https://github.com/github/primer/issues/5424 and https://github.com/github/primer/issues/5828
Changelog
Removed
Rollout strategy
Testing & Reviewing
Merge checklist