Skip to content

Conversation

francinelucca
Copy link
Member

Reverts #6941

Reverting due to CI failures

Copy link

changeset-bot bot commented Oct 8, 2025

⚠️ No Changeset found

Latest commit: bf31fa0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@francinelucca francinelucca marked this pull request as ready for review October 8, 2025 06:11
@francinelucca francinelucca requested a review from a team as a code owner October 8, 2025 06:11
@github-actions github-actions bot added the staff Author is a staff member label Oct 8, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the removal of styled-components from various components in the Primer React library, restoring them to their styled-components implementation due to CI failures. The revert affects multiple components including UnderlineNav, Tooltip, LabelGroup, ValidationAnimationContainer, and related utilities.

Key Changes:

  • Restores styled-components usage across multiple deprecated and internal components
  • Reverts CSS module migration back to styled-components for affected components
  • Re-adds styled-system type support and responsive value handling

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/src/internal/utils/sharedCheckboxAndRadioStyles.ts Re-adds shared styled-components styles for checkbox and radio inputs
packages/react/src/internal/components/ValidationAnimationContainer.tsx Reverts from CSS modules back to styled-components for animation implementation
packages/react/src/internal/components/ValidationAnimationContainer.module.css Removes CSS module file that was replaced by styled-components
packages/react/src/internal/components/TextInputWrapper.tsx Re-adds ResponsiveValue type support and conditional style handling
packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx Re-adds SxProp support to component interfaces
packages/react/src/deprecated/UnderlineNav/UnderlineNav.tsx Reverts from CSS modules to styled-components implementation
packages/react/src/deprecated/UnderlineNav/UnderlineNav.module.css Removes CSS module file replaced by styled-components
packages/react/src/deprecated/ActionList/Item.tsx Restores theme function usage for CSS variable assignment
packages/react/src/UnderlineNav/UnderlineNav.tsx Re-adds styled-components for MoreMenuListItem component
packages/react/src/Truncate/Truncate.tsx Re-adds MaxWidthProps support from styled-system
packages/react/src/Tooltip/Tooltip.tsx Reverts from CSS modules to comprehensive styled-components implementation
packages/react/src/Tooltip/Tooltip.module.css Removes CSS module file replaced by styled-components
packages/react/src/TextInput/TextInput.tsx Minor prop reordering change
packages/react/src/TextInput/TextInput.docs.json Updates prop type documentation to include responsive arrays
packages/react/src/Text/Text.tsx Re-adds styled-system type support and StyledComponent typing
packages/react/src/SkeletonAvatar/SkeletonAvatar.tsx Adds merge utility usage for style object combination
packages/react/src/Skeleton/SkeletonBox.tsx Adds merge utility usage for style object combination
packages/react/src/SegmentedControl/SegmentedControl.features.stories.tsx Updates stories to use component props instead of inline styles
packages/react/src/PageLayout/PageLayout.examples.stories.tsx Adds large commented code block for potential future feature
packages/react/src/LabelGroup/LabelGroup.tsx Reverts from CSS modules to styled-components implementation
packages/react/src/LabelGroup/LabelGroup.module.css Removes most CSS module styles replaced by styled-components
packages/react/src/FormControl/FormControlLeadingVisual.tsx Replaces CSS custom properties with theme function calls
packages/react/src/DialogV1/Dialog.test.tsx Updates test component to use fontFamily prop instead of inline styles
.changeset/chilled-spoons-roll.md Removes changeset file for the reverted styled-components removal

Copy link
Contributor

github-actions bot commented Oct 8, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@francinelucca francinelucca added this pull request to the merge queue Oct 8, 2025
Merged via the queue into main with commit cbcaff0 Oct 8, 2025
46 checks passed
@francinelucca francinelucca deleted the revert-6941-chore/remove-styled-system branch October 8, 2025 10:09
francinelucca added a commit that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants