-
Notifications
You must be signed in to change notification settings - Fork 639
Revert "Chore: remove styled system components" #6964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit a67df3e.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts the removal of styled-components from various components in the Primer React library, restoring them to their styled-components implementation due to CI failures. The revert affects multiple components including UnderlineNav, Tooltip, LabelGroup, ValidationAnimationContainer, and related utilities.
Key Changes:
- Restores styled-components usage across multiple deprecated and internal components
- Reverts CSS module migration back to styled-components for affected components
- Re-adds styled-system type support and responsive value handling
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/react/src/internal/utils/sharedCheckboxAndRadioStyles.ts | Re-adds shared styled-components styles for checkbox and radio inputs |
packages/react/src/internal/components/ValidationAnimationContainer.tsx | Reverts from CSS modules back to styled-components for animation implementation |
packages/react/src/internal/components/ValidationAnimationContainer.module.css | Removes CSS module file that was replaced by styled-components |
packages/react/src/internal/components/TextInputWrapper.tsx | Re-adds ResponsiveValue type support and conditional style handling |
packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx | Re-adds SxProp support to component interfaces |
packages/react/src/deprecated/UnderlineNav/UnderlineNav.tsx | Reverts from CSS modules to styled-components implementation |
packages/react/src/deprecated/UnderlineNav/UnderlineNav.module.css | Removes CSS module file replaced by styled-components |
packages/react/src/deprecated/ActionList/Item.tsx | Restores theme function usage for CSS variable assignment |
packages/react/src/UnderlineNav/UnderlineNav.tsx | Re-adds styled-components for MoreMenuListItem component |
packages/react/src/Truncate/Truncate.tsx | Re-adds MaxWidthProps support from styled-system |
packages/react/src/Tooltip/Tooltip.tsx | Reverts from CSS modules to comprehensive styled-components implementation |
packages/react/src/Tooltip/Tooltip.module.css | Removes CSS module file replaced by styled-components |
packages/react/src/TextInput/TextInput.tsx | Minor prop reordering change |
packages/react/src/TextInput/TextInput.docs.json | Updates prop type documentation to include responsive arrays |
packages/react/src/Text/Text.tsx | Re-adds styled-system type support and StyledComponent typing |
packages/react/src/SkeletonAvatar/SkeletonAvatar.tsx | Adds merge utility usage for style object combination |
packages/react/src/Skeleton/SkeletonBox.tsx | Adds merge utility usage for style object combination |
packages/react/src/SegmentedControl/SegmentedControl.features.stories.tsx | Updates stories to use component props instead of inline styles |
packages/react/src/PageLayout/PageLayout.examples.stories.tsx | Adds large commented code block for potential future feature |
packages/react/src/LabelGroup/LabelGroup.tsx | Reverts from CSS modules to styled-components implementation |
packages/react/src/LabelGroup/LabelGroup.module.css | Removes most CSS module styles replaced by styled-components |
packages/react/src/FormControl/FormControlLeadingVisual.tsx | Replaces CSS custom properties with theme function calls |
packages/react/src/DialogV1/Dialog.test.tsx | Updates test component to use fontFamily prop instead of inline styles |
.changeset/chilled-spoons-roll.md | Removes changeset file for the reverted styled-components removal |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
This reverts commit cbcaff0.
Reverts #6941
Reverting due to CI failures