chore: ActionList use forwardedAs in subcomponents #6995
Merged
+59
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d33bcfc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Update ActionList to use forwardedAs in its subcomponents.
There was a problem hiding this comment.
Pull Request Overview
This PR adds forwardedAs support to ActionList subcomponents by modifying their type definitions and implementation patterns. The changes enable these components to use custom HTML elements while maintaining styled-components compatibility.
Key changes:
- Added
as?: React.ElementTypeto type definitions for LinkItem, Group, LeadingVisual, and TrailingVisual components - Refactored components to use wrapper pattern that forwards the
asprop asforwardedAsto styled components - Renamed existing styled components with
Styledprefix to distinguish from new wrapper components
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-actions
bot
requested a deployment
to
storybook-preview-6995
TylerJDev
approved these changes
Oct 13, 2025
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/4464 |
github-actions
bot
added
the
integration-tests: failing
|
🟢 ci completed with status |
github-actions
bot
added
integration-tests: passing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add forwardedAs wrapper to styled-components in ActionList subcomponets to prevent override
Changelog
New
Rollout strategy
Testing & Reviewing
Merge checklist