Skip to content

add size prop #7076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+39 −8
Draft

add size prop #7076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions packages/react/src/Dialog/Dialog.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,16 +101,13 @@

.Dialog {
display: flex;
/* stylelint-disable-next-line primer/responsive-widths */
width: 640px;
min-width: 296px;
width: min(var(--overlay-width), 100vw - 2rem);
min-width: var(--overlay-width-xsmall);
max-width: calc(100dvw - 64px);
height: auto;
max-height: calc(100dvh - 64px);
max-height: min(calc(100dvh - 2rem), var(--overlay-height));
flex-direction: column;
background-color: var(--overlay-bgColor);
border-radius: var(--borderRadius-large);
border-radius: var(--borderRadius-large, var(--borderRadius-large));
box-shadow: var(--shadow-floating-small);
opacity: 1;

Expand All @@ -135,6 +132,30 @@
height: 640px;
}

&:where([data-height='auto']) {
height: auto;
}

&:where([data-size='small']) {
--overlay-height: var(--overlay-height-small);
--overlay-width: var(--overlay-width-small);
}

&:where([data-size='medium']) {
--overlay-height: var(--overlay-height-medium);
--overlay-width: var(--overlay-width-medium);
}

&:where([data-size='large']) {
--overlay-height: var(--overlay-height-large);
--overlay-width: var(--overlay-width-large);
}

&:where([data-size='xlarge']) {
--overlay-height: var(--overlay-height-xlarge);
--overlay-width: var(--overlay-width-xlarge);
}

@media screen and (prefers-reduced-motion: no-preference) {
animation: Overlay--motion-scaleFade 0.2s cubic-bezier(0.33, 1, 0.68, 1) 1ms 1 normal none running;
}
Expand Down
8 changes: 7 additions & 1 deletion packages/react/src/Dialog/Dialog.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,19 @@ export const Playground = (
)
}
Playground.args = {
width: 'xlarge',
size: 'large',
height: 'auto',
subtitle: 'Subtitle',
title: 'Dialog heading',
position: 'center',
}
Playground.argTypes = {
size: {
control: {
type: 'radio',
},
options: ['small', 'medium', 'large', 'xlarge'],
},
width: {
control: {
type: 'radio',
Expand Down
6 changes: 5 additions & 1 deletion packages/react/src/Dialog/Dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ export interface DialogProps {
*/
height?: DialogHeight

size?: 'small' | 'medium' | 'large' | 'xlarge'

/**
* The position of the dialog
*/
Expand Down Expand Up @@ -236,8 +238,9 @@ const _Dialog = React.forwardRef<HTMLDivElement, React.PropsWithChildren<DialogP
renderFooter,
onClose,
role = 'dialog',
width = 'xlarge',
width,
height = 'auto',
size = 'large',
footerButtons = defaultFooterButtons,
position = defaultPosition,
returnFocusRef,
Expand Down Expand Up @@ -325,6 +328,7 @@ const _Dialog = React.forwardRef<HTMLDivElement, React.PropsWithChildren<DialogP
{...positionDataAttributes}
data-width={width}
data-height={height}
data-size={size}
className={clsx(className, classes.Dialog)}
>
{header}
Expand Down
Loading