Skip to content

Remove breadcrumbs overflow menu feature flag #7081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Remove breadcrumbs overflow menu feature flag #7081

wants to merge 5 commits into from

Conversation

@pksjce
Copy link
Contributor

@pksjce pksjce commented Oct 27, 2025

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@pksjce pksjce requested a review from a team as a code owner October 27, 2025 05:55
@pksjce pksjce requested review from TylerJDev and Copilot October 27, 2025 05:55
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 858a265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@primer/react Patch
@primer/styled-react Patch
@primer/mcp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI reviewed Oct 27, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the primer_react_breadcrumbs_overflow_menu feature flag, making the breadcrumbs overflow menu functionality always enabled. The feature flag was being used to gate the overflow menu behavior, and its removal indicates the feature is ready for general availability.

Key changes:

  • Removed the feature flag definition and all its usages
  • Simplified the Breadcrumbs component by removing conditional logic based on the flag
  • Updated tests and stories to remove feature flag wrapping

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
DefaultFeatureFlags.ts Removed the primer_react_breadcrumbs_overflow_menu flag from the default flags object
Breadcrumbs.test.tsx Removed feature flag wrapper from tests and simplified the helper function
Breadcrumbs.tsx Removed feature flag hook usage and conditional rendering logic
Breadcrumbs.features.stories.tsx Removed feature flag wrappers from stories and renamed stories to remove flag references

packages/react/src/Breadcrumbs/__tests__/Breadcrumbs.test.tsx Outdated
Comment on lines 5 to 6
// Helper function kept for symmetry (flags removed); directly renders component
const renderWithTheme = (component: React.ReactElement) => HTMLRender(component)
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The renderWithTheme helper function no longer serves a purpose beyond wrapping HTMLRender. Consider removing it entirely and calling HTMLRender directly in tests, or update the comment to better explain why this abstraction is being maintained.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@pksjce pksjce Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copilot AI mentioned this pull request Oct 27, 2025
Merged
Copy link
Contributor

Copilot AI commented Oct 27, 2025

@pksjce I've opened a new pull request, #7082, to work on those changes. Once the pull request is ready, I'll request review from you.

@github-actions github-actions bot requested a deployment to storybook-preview-7081 October 27, 2025 06:00 Abandoned
@primer-integration
Copy link

primer-integration bot commented Oct 27, 2025

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/5654

@github-actions github-actions bot temporarily deployed to storybook-preview-7081 October 27, 2025 06:12 Inactive
@primer-integration
Copy link

primer-integration bot commented Oct 27, 2025

🔴 ci completed with status failure.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 27, 2025
@pksjce
Remove unused renderWithTheme helper from Breadcrumbs tests (#7082)
53bdd38 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pksjce <417268+pksjce@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to storybook-preview-7081 October 27, 2025 12:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@TylerJDev TylerJDev TylerJDev approved these changes

Assignees

No one assigned

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pksjce @TylerJDev @francinelucca