Use Banner.Title as default label for landmark region via aria-labelledby #7099
+104
−68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Banners previously labeled their landmark regions with generic variant names ("Information", "Critical", etc.) via
aria-label. This provides limited context to screen reader users. Banner regions should be labeled by their actual title content.Changes
aria-labelledbyto reference its title, whether provided viatitleprop orBanner.Titlechild componentBannerContextto share generated title IDs between Banner and Banner.TitleuseIdhook to generate unique IDs for title elementsaria-labelandaria-labelledbyprops continue to work as overridesPriority order
aria-labelledby(highest)aria-labelaria-labelledbyreferencing title (default)Example
Before:
After:
Works with both approaches:
Original prompt
Banner.Titleas the default label for the landmark region #6590💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.