Skip to content

Remove next-major branch references from workflows #7104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove next-major branch references from workflows #7104

wants to merge 4 commits into from
+0 −23

Conversation

Copy link
Contributor

Copilot AI commented Oct 30, 2025 •
edited
Loading

  • Remove next-major from branches-ignore in .github/workflows/release_canary.yml
  • Remove next-major from branches trigger in .github/workflows/ci.yml (2 occurrences)
  • Remove next-major from branches trigger in .github/workflows/release.yml
  • Remove entire release-next-major job from .github/workflows/release.yml
  • Remove changeset-release/next-major from branches in .github/workflows/release_candidate.yml
  • Remove next-major from branches trigger in .github/workflows/reports.yml (2 occurrences)
  • Remove mock data references to next-major branches in packages/react/src/experimental/SelectPanel2/mock-story-data.ts
  • Verify all changes with format, lint, build, and test

All references to the deprecated next-major branch have been successfully removed from the codebase. The next-major branch was previously used to collect changes for major releases, but this workflow is no longer followed.

Original prompt

This section details on the original issue you should resolve

<issue_title>Remove next-major from workflows</issue_title>
<issue_description>We used to have a next-major branch to collect changes for the next major release. We no longer follow this approach. However there are still remnants of this left in the workflows, let's remove them.</issue_description>

Comments on the Issue (you are @copilot in this section)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: bd5fc8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp
Remove next-major branch references from workflows and mock data
a766dff 
Co-authored-by: siddharthkp <1863771+siddharthkp@users.noreply.github.com>
siddharthkp
siddharthkp reviewed Oct 30, 2025
View reviewed changes
packages/react/src/experimental/SelectPanel2/mock-story-data.ts
{id: 'main', name: 'main', trailingInfo: 'Default'},
{id: 'next-major', name: 'next-major'},
{id: 'changeset-release/main', name: 'changeset-release/main'},
{id: 'changeset-release/next-major', name: 'changeset-release/next-major'},
Copy link
Member

@siddharthkp siddharthkp Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol but sure

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copilot AI changed the title [WIP] Remove next-major references from workflows Remove next-major branch references from workflows Oct 30, 2025
Copilot AI requested a review from siddharthkp October 30, 2025 18:08
Copilot finished work on behalf of siddharthkp October 30, 2025 18:08
@github-actions github-actions bot temporarily deployed to storybook-preview-7104 October 30, 2025 18:10 Inactive
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Oct 30, 2025
siddharthkp
siddharthkp approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, well done!

@siddharthkp siddharthkp marked this pull request as ready for review October 30, 2025 19:21
@siddharthkp siddharthkp requested a review from a team as a code owner October 30, 2025 19:21
@siddharthkp siddharthkp requested review from Copilot and pksjce October 30, 2025 19:21
@siddharthkp siddharthkp added the integration-tests: skipped manually Changes in this PR do not require an integration test label Oct 30, 2025
Copilot AI reviewed Oct 30, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all references to the deprecated next-major branch from the codebase. The next-major branch was previously used to collect changes for major releases, but this workflow is no longer followed and the remnants needed cleanup.

Key changes:

  • Removed next-major branch triggers from CI/CD workflows (ci.yml, reports.yml, release_canary.yml, release_candidate.yml)
  • Removed the entire release-next-major job from the release workflow
  • Removed next-major and changeset-release/next-major branch entries from SelectPanel2 test mock data

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/ci.yml Removed next-major from push and merge_group branch triggers
.github/workflows/reports.yml Removed next-major from push and merge_group branch triggers
.github/workflows/release_candidate.yml Removed next-major from changeset-release branch triggers
.github/workflows/release_canary.yml Removed next-major from branches-ignore list
.github/workflows/release.yml Removed entire release-next-major job and associated configuration
packages/react/src/experimental/SelectPanel2/mock-story-data.ts Removed next-major and changeset-release/next-major branch entries from test fixtures

@siddharthkp
Copy link
Member

siddharthkp commented Oct 31, 2025

@copilot Can you perform this task again after merging main?

@siddharthkp
Merge main branch - workflows consolidated, next-major already removed
eb1bbe4 
Co-authored-by: siddharthkp <1863771+siddharthkp@users.noreply.github.com>
Copilot AI requested a review from a team as a code owner October 31, 2025 22:59
Copilot AI requested a review from mperrotti October 31, 2025 22:59
Copy link
Contributor Author

Copilot AI commented Oct 31, 2025

@copilot Can you perform this task again after merging main?

Done! Merged main into the PR branch (commit eb1bbe4). The workflows have been consolidated in main - release_canary.yml and release_candidate.yml were removed and integrated into release.yml. Confirmed no next-major references exist anywhere in the codebase after the merge.

Copilot AI requested a review from siddharthkp October 31, 2025 23:01
Copilot finished work on behalf of siddharthkp October 31, 2025 23:01
@siddharthkp
Copy link
Member

siddharthkp commented Oct 31, 2025

@copilot Oof, that's not it. Revert last commit

Copy link
Contributor Author

Copilot AI commented Oct 31, 2025

@copilot Oof, that's not it. Revert last commit

Reverted the merge commit in bd5fc8b. The PR is back to the state before the merge, with all the original next-major removal changes intact.

Copilot finished work on behalf of siddharthkp October 31, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jonrohan jonrohan jonrohan approved these changes

@pksjce pksjce Awaiting requested review from pksjce pksjce is a code owner automatically assigned from primer/engineer-reviewers

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti was automatically assigned from primer/design-reviewers

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

Assignees

@siddharthkp siddharthkp

Copilot code review Copilot

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[task for 🤖] Remove next-major from workflows

3 participants

@siddharthkp @jonrohan