Skip to content

ActionBar: Remove data-testid #7115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ActionBar: Remove data-testid #7115

wants to merge 5 commits into from
+5 −1

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Oct 31, 2025 •
edited
Loading

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@siddharthkp siddharthkp requested a review from a team as a code owner October 31, 2025 21:42
@siddharthkp siddharthkp requested review from Copilot and pksjce October 31, 2025 21:42
@siddharthkp siddharthkp self-assigned this Oct 31, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 05a0b85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Patch
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp requested a review from TylerJDev October 31, 2025 21:42
@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copilot AI reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an auto-generated data-testid attribute from the ActionBarIconButton component. The change cleans up unnecessary test-specific markup that was not being used by any tests.

  • Removes auto-generated data-testid={id} from ActionBarIconButton

@github-actions github-actions bot requested a deployment to storybook-preview-7115 October 31, 2025 21:48 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-7115 October 31, 2025 21:56 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 31, 2025
@siddharthkp
Copy link
Member Author

siddharthkp commented Oct 31, 2025 •
edited
Loading

Expecting CI failures 😢

@github-actions github-actions bot temporarily deployed to storybook-preview-7115 November 3, 2025 01:50 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-7115 November 3, 2025 11:41 Inactive
@primer-integration
Copy link

primer-integration bot commented Nov 4, 2025

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/6235

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Nov 4, 2025
@primer-integration
Copy link

primer-integration bot commented Nov 4, 2025

🟢 ci completed with status success.

@joshblack
Copy link
Member

joshblack commented Nov 4, 2025

@siddharthkp hope you don't mind, I used your PR to test out the new github-ui status checks 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@pksjce pksjce pksjce approved these changes

@TylerJDev TylerJDev TylerJDev approved these changes

Assignees

@siddharthkp siddharthkp

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@siddharthkp @joshblack @pksjce @TylerJDev