Skip to content

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Nov 10, 2025

Closes https://github.com/github/primer/issues/5248

Changelog

New

  • Add the TopicTag component along with a helper TopicTag.Group component for layout

Changed

Removed

Rollout strategy

  • Minor release

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2025

🦋 Changeset detected

Latest commit: 2cb5652

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 10, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions github-actions bot requested a deployment to storybook-preview-7177 November 10, 2025 18:22 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-7177 November 10, 2025 18:28 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-7177 November 10, 2025 18:37 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-7177 November 10, 2025 19:48 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-7177 November 10, 2025 19:57 Inactive
Copy link
Contributor

@lukasoppermann lukasoppermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design looks great. 👍

@joshblack joshblack marked this pull request as ready for review November 20, 2025 16:02
Copy link
Contributor

@hectahertz hectahertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, nice and clean ✨

color: var(--fgColor-onEmphasis);
}

/* Add a reset to when TopicTag is an <a> element since our link styles apply an underline text-decoration by default */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this explanation! ✨

@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 21, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-7177 November 21, 2025 18:29 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 21, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-7177 November 21, 2025 18:39 Inactive
@joshblack joshblack added this pull request to the merge queue Nov 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2025
@joshblack joshblack added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit feb7001 Nov 21, 2025
49 checks passed
@joshblack joshblack deleted the feat/add-topic-tag-component branch November 21, 2025 23:11
@primer primer bot mentioned this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants