-
Notifications
You must be signed in to change notification settings - Fork 646
feat: add TopicTag component #7177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2cb5652 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
lukasoppermann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design looks great. 👍
hectahertz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this, nice and clean ✨
| color: var(--fgColor-onEmphasis); | ||
| } | ||
|
|
||
| /* Add a reset to when TopicTag is an <a> element since our link styles apply an underline text-decoration by default */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this explanation! ✨
Closes https://github.com/github/primer/issues/5248
Changelog
New
TopicTagcomponent along with a helperTopicTag.Groupcomponent for layoutChanged
Removed
Rollout strategy