You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: ⚠️ This is a WIP PR, the approach here can be changed as there's multiple ways of tackling this issue.
Added automatic overflow detection and handling in ButtonGroup.tsx, including logic to measure button widths, calculate how many buttons fit, and move excess buttons into an overflow menu triggered by an icon button. The overflow menu uses AnchoredOverlay for accessibility and keyboard navigation.
Introduced the overflowAriaLabel prop to ButtonGroup, with a default value of "More actions", ensuring the overflow trigger button is accessible to screen readers.
Changelog
New
Changed
Removed
Rollout strategy
Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
integration-tests: recommended
hectahertz
changed the title
Closes https://github.com/github/primer/issues/6096
ButtonGroup.tsx, including logic to measure button widths, calculate how many buttons fit, and move excess buttons into an overflow menu triggered by an icon button. The overflow menu usesAnchoredOverlayfor accessibility and keyboard navigation.overflowAriaLabelprop toButtonGroup, with a default value of "More actions", ensuring the overflow trigger button is accessible to screen readers.Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist