-
Notifications
You must be signed in to change notification settings - Fork 645
Add React-first version of UnderlinePanels #7225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 19bdfe3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
😢 Hi from github/github-ui. The integration workflow has failed: https://github.com/github/github-ui/actions/runs/19583716011 |
Introduces a new
UnderlinePanels2component which utilizes the newTabsutility. This is intended to address the usability issues that have come up with the mixing oftab-container-elementbacking the currentUnderlinePanelscomponent. See #7093, #7092, #6253, #6250I explicitly copied over the VRT snapshots from the current component to ensure 1:1 consistency with the behavior. All stories have also been copied to mirror the current component.
The goal is to convert usage of the current
UnderlinePanelscomponent to the new one for removal in a future major version.Changelog
New
New
UnderlinePanels2component as a replacement for the existingUnderlinePanelsRollout strategy
Testing & Reviewing
Merge checklist