Skip to content

Conversation

@pksjce
Copy link
Contributor

@pksjce pksjce commented Nov 21, 2025

No description provided.

@pksjce pksjce requested a review from joshblack November 21, 2025 12:17
@pksjce pksjce self-assigned this Nov 21, 2025
@pksjce pksjce requested a review from a team as a code owner November 21, 2025 12:17
Copilot AI review requested due to automatic review settings November 21, 2025 12:17
@pksjce pksjce added the skip changeset This change does not need a changelog label Nov 21, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

⚠️ No Changeset found

Latest commit: c464997

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot finished reviewing on behalf of pksjce November 21, 2025 12:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the release candidate workflow to ensure that both @primer/react and @primer/styled-react packages receive RC versions when creating release candidates. Previously, only @primer/react was versioned with the RC suffix. The change adapts this monorepo's release process to accommodate the styled-react package, which serves as a temporary bridge package between Primer React and styled-components.

Key Changes

  • Modified the release-candidate job to loop through both package.json files (react and styled-react) when creating RC versions
  • Applied the same RC version suffix pattern (-rc.<git-sha>) to both packages for consistency

@pksjce pksjce removed the skip changeset This change does not need a changelog label Nov 21, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-7227 November 21, 2025 12:22 Abandoned
Update the release workflow to generate a release candidate for styled-react.
@github-actions github-actions bot requested a deployment to storybook-preview-7227 November 21, 2025 12:30 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-7227 November 21, 2025 12:39 Inactive
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one comment, otherwise looks good! Thanks for doing this 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to omit this since we're not updating the public API or anything 👀

@pksjce pksjce added the skip changeset This change does not need a changelog label Nov 24, 2025
@pksjce pksjce enabled auto-merge November 24, 2025 02:57
@github-actions github-actions bot temporarily deployed to storybook-preview-7227 November 24, 2025 03:07 Inactive
@pksjce pksjce added this pull request to the merge queue Nov 24, 2025
Merged via the queue into main with commit 686ced9 Nov 24, 2025
49 checks passed
@pksjce pksjce deleted the pk/fix-styled-react-rc-version branch November 24, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants