-
Notifications
You must be signed in to change notification settings - Fork 645
fix: update release workflow to create an rc for styled-react #7227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the release candidate workflow to ensure that both @primer/react and @primer/styled-react packages receive RC versions when creating release candidates. Previously, only @primer/react was versioned with the RC suffix. The change adapts this monorepo's release process to accommodate the styled-react package, which serves as a temporary bridge package between Primer React and styled-components.
Key Changes
- Modified the release-candidate job to loop through both package.json files (react and styled-react) when creating RC versions
- Applied the same RC version suffix pattern (
-rc.<git-sha>) to both packages for consistency
Update the release workflow to generate a release candidate for styled-react.
joshblack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had one comment, otherwise looks good! Thanks for doing this 🙏
.changeset/short-ladybugs-fly.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to omit this since we're not updating the public API or anything 👀
No description provided.