-
Notifications
You must be signed in to change notification settings - Fork 647
Improve PageLayout pane drag performance with pointer capture and GPU-accelerated transforms #7307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mattcosta7
merged 8 commits into
main
from
revert-7305-revert-7275-revert-7274-revert-7251-mc/copilot/sub-pr-7248
Dec 15, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
83540ae
Revert "Revert "Revert "Revert "Improve PageLayout pane drag performa…
mattcosta7 8b08d12
Removes a resize subscription and expensive `:has` selectors from pag…
mattcosta7 0fb5ee5
Update shiny-buckets-study.md
mattcosta7 09eda58
resize-improvemet (#7310)
mattcosta7 5817e16
initialize from localStorage, suppressing hydration error
mattcosta7 d0dd7d0
abckout snapshot
mattcosta7 ae89c0d
keep cursor closer to edge
mattcosta7 b2e840f
Merge branch 'main' into revert-7305-revert-7275-revert-7274-revert-7…
mattcosta7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@primer/react': patch | ||
| --- | ||
|
|
||
| reapplies PageLayout resizable enhancements without INP drop from expensive selectors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we have prefernces for using these across JS/CSS or just duplicating them?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about :export
Sorry, trying to understand the goal here. Why are these exported from PageLayout.module.css? We don't use them in this fileNevermind, I realise you can't use the exports within the file because they will be removed during compilation