You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request refactors the pane width logic in the PageLayout component by extracting width-related calculations and state management into a new usePaneWidth hook. This improves code organization, maintainability, and performance, while also enhancing accessibility features and test coverage for drag and resize interactions.
Refactor and code organization:
Extracted pane width logic (including width calculation, constraints, persistence, and ARIA updates) from PageLayout.tsx into a new usePaneWidth hook, simplifying the main component and centralizing related functionality. [1][2][3][4][5][6][7][8]
Testing improvements:
Added tests to verify that the data-dragging attribute is correctly set on the content area during both pointer and keyboard resizing, ensuring accessibility and UI feedback during interactions.
CSS and responsive design enhancements:
Exported CSS custom properties (such as paneMaxWidthDiffBreakpoint and paneMaxWidthDiffDefault) for use in JavaScript, improving synchronization between CSS breakpoints and JS logic.
Added comments and exported values in PageLayout.module.css to clarify the relationship between CSS variables and their usage in the new hook and component logic. [1][2]
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
integration-tests: recommended
mattcosta7
merged commit 
This pull request refactors the pane width logic in the
PageLayoutcomponent by extracting width-related calculations and state management into a newusePaneWidthhook. This improves code organization, maintainability, and performance, while also enhancing accessibility features and test coverage for drag and resize interactions.Refactor and code organization:
PageLayout.tsxinto a newusePaneWidthhook, simplifying the main component and centralizing related functionality. [1] [2] [3] [4] [5] [6] [7] [8]Testing improvements:
data-draggingattribute is correctly set on the content area during both pointer and keyboard resizing, ensuring accessibility and UI feedback during interactions.CSS and responsive design enhancements:
paneMaxWidthDiffBreakpointandpaneMaxWidthDiffDefault) for use in JavaScript, improving synchronization between CSS breakpoints and JS logic.PageLayout.module.cssto clarify the relationship between CSS variables and their usage in the new hook and component logic. [1] [2]