-
Notifications
You must be signed in to change notification settings - Fork 650
Change actionlist item inline description styling #7427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
barmo
wants to merge
11
commits into
main
Choose a base branch
from
clara/actionlist-item-inline-description-overflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−9
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ea3c1ee
change actionlist item inline description styling from flex to block …
barmo 0d62018
add patch changelog
barmo 1e011b3
Merge branch 'main' into clara/actionlist-item-inline-description-ove…
barmo 7af4ab1
Merge branch 'main' into clara/actionlist-item-inline-description-ove…
barmo 199b42f
Merge branch 'main' into clara/actionlist-item-inline-description-ove…
barmo 9f6ac86
Prevents extra vertical spacing when using block/inline layout for th…
barmo 9ec12e1
add disable comment
barmo 257fe7f
test(vrt): update snapshots
barmo 25531d8
remove unecessary display:inline
barmo 1a5564c
Merge branch 'main' into clara/actionlist-item-inline-description-ove…
jonrohan dc2ac3d
Merge branch 'main' into clara/actionlist-item-inline-description-ove…
barmo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@primer/react': patch | ||
| --- | ||
|
|
||
| Change actionlist item inline description styling from flex to block to fix overflow |
Binary file modified
BIN
-249 Bytes
(99%)
...ionList.test.ts-snapshots/ActionList-All-combinations-dark-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-284 Bytes
(99%)
.../ActionList.test.ts-snapshots/ActionList-All-combinations-dark-dimmed-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-276 Bytes
(99%)
...List.test.ts-snapshots/ActionList-All-combinations-dark-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-249 Bytes
(99%)
...ponents/ActionList.test.ts-snapshots/ActionList-All-combinations-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-249 Bytes
(99%)
...ionList.test.ts-snapshots/ActionList-All-combinations-dark-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-271 Bytes
(99%)
...onList.test.ts-snapshots/ActionList-All-combinations-light-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-218 Bytes
(100%)
...ist.test.ts-snapshots/ActionList-All-combinations-light-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-271 Bytes
(99%)
...onents/ActionList.test.ts-snapshots/ActionList-All-combinations-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-271 Bytes
(99%)
...onList.test.ts-snapshots/ActionList-All-combinations-light-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting the
line-heightwas necessary because with flex previously, the container height is determined by the tallest item's content. With thedisplay:block, the block/inline layout inherits line-height from ancestor elements, which can vary depending on context and create extra vertical spacing. We need to reset this to prevent the spacing mismatch.Including the disable instead of using a Primer typography variable was necessary because