Fixing issue in utilities plugin (#274)

* Fixing issue in utilities plugin * Create large-lemons-arrive.md
primer · May 27, 2022 · 4ba7018 · 4ba7018
1 parent 3aeb950
commit 4ba7018
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/.changeset/large-lemons-arrive.md b/.changeset/large-lemons-arrive.md
@@ -0,0 +1,5 @@
+---
+"@primer/stylelint-config": patch
+---
+
+Fixing issue in utilities plugin that missed certain classes
diff --git a/__tests__/utilities.js b/__tests__/utilities.js
@@ -29,6 +29,14 @@ testRule({
       column: 1,
       description: 'Errors on spacer utility.'
     },
+    {
+      code: '.x { padding: 1px; &:hover { padding:2px; } } .x { padding: $spacer-4; }',
+      message:
+        "Consider using the Primer utility '.p-4' instead of the selector '.x' in your html. https://primer.style/css/utilities (primer/utilities)",
+      line: 1,
+      column: 47,
+      description: 'Errors on spacer utility with hover ampersand.'
+    },
     {
       code: '.x { padding: $spacer-4 !important; }',
       message:

diff --git a/plugins/utilities.js b/plugins/utilities.js
@@ -27,7 +27,7 @@ module.exports = stylelint.createPlugin(ruleName, (enabled, options = {}, contex
   const lintResult = (root, result) => {
     root.walkRules(rule => {
       if (!/^\.[\w\-_]+$/.exec(rule.selector)) {
-        return false
+        return
       }
       const decls = rule.nodes.filter(decl => decl.type === 'decl')