Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FormControl styles to PVC #1638

Merged
merged 17 commits into from
Dec 2, 2022
Merged

Move FormControl styles to PVC #1638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4ff6368
Add FormControl styles from PCSS
simurai Nov 25, 2022
2b90d69
Convert FormControl .scss to .pcss
simurai Nov 25, 2022
8c2ef5d
Add `form-control` styles from PCSS
simurai Nov 25, 2022
aae1b5b
Temporarily override fieldset
simurai Nov 25, 2022
075c5b4
Remove old form_control styles again
simurai Nov 25, 2022
66e9a8a
Create gentle-pugs-happen.md
simurai Nov 25, 2022
033bb6c
Generating component snapshots
simurai Nov 25, 2022
dc9f05c
Move form_control.pcss to
simurai Nov 25, 2022
1bc6f99
Disable`logical-properties-and-values`
simurai Nov 25, 2022
90c63a7
Generating component snapshots
simurai Nov 25, 2022
d839f63
Temporarily add `::placeholder`
simurai Nov 25, 2022
8f6bce7
Rename form_control to text_field
simurai Nov 28, 2022
b6ea785
Add forms import back
simurai Nov 28, 2022
231619b
Generating component snapshots
simurai Nov 28, 2022
19e44c1
Fix placeholder selector
simurai Nov 28, 2022
527188b
Update previews
simurai Nov 28, 2022
1727564
Merge branch 'main' into forms-pcss
simurai Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gentle-pugs-happen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/view-components": patch
---

Move `FormControl` styles to PVC
Binary file modified ...nshots/previews.test.ts-snapshots/primer/beta/auto_complete_preview/default.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...nshots/previews.test.ts-snapshots/primer/beta/auto_complete_preview/focused.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading