Refactor Dialog to use <dialog> internally
#2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cb630a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as resolved.
This comment was marked as resolved.
keithamus
changed the title
<dialog> internally
keithamus
force-pushed
the
refactor-dialog-to-use-dialog-internally
branch
from
efa5fb8
to
67ab782
Compare
camertron
approved these changes
Jan 11, 2024
keithamus
force-pushed
the
refactor-dialog-to-use-dialog-internally
branch
from
1354ec4
to
ed08a37
Compare
keithamus
force-pushed
the
refactor-dialog-to-use-dialog-internally
branch
from
ed08a37
to
ffea5f9
Compare
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
lukasoppermann
approved these changes
Jan 17, 2024
Merged
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
This is a re-attempt at #2364 with some additional bugs fixed.
This PR changes
Dialogto no longer use themodal-dialogelement we had created to "ponyfill" the native dialog element. Now that native<dialog>is well supported, we can simply use that and remove the vast majority of our code.We still need a
<dialog-helper>element for 2 features:dialog-show/close-idattributes. These will be resolved one day by Invokers (Add commandfor & command attributes to HTMLButtonElement whatwg/html#9841)Screenshots
It is identical in appearance.
Integration
Yes there is a subtle difference which we'll need to change code in dotcom for.
Our
modal-dialogelement mistakenly dispatches thecancelorcloseevents on a dialog.List the issues that this change affects.
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.