Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing minitest dependency line from Gemfile #2602

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

jonrohan
Copy link
Member

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Cleaning up the Gemfile noticed this line was meant to be temporary. The issue is resolved so removing the line freerange/mocha#614

  # Disallow v5.19 for now since it breaks mocha.
  # See: https://github.com/freerange/mocha/issues/614
  # Remove this line when mocha has fixed the issue
  gem "minitest", "< 5.22"

@jonrohan jonrohan requested review from camertron and a team February 13, 2024 00:41
Copy link

changeset-bot bot commented Feb 13, 2024

⚠️ No Changeset found

Latest commit: af5b012

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonrohan jonrohan added the skip changeset Pull requests that don't change the library output label Feb 13, 2024
@jonrohan jonrohan enabled auto-merge (squash) February 13, 2024 00:43
@jonrohan jonrohan merged commit da17a11 into main Feb 14, 2024
33 of 34 checks passed
@jonrohan jonrohan deleted the remove_minitest_line branch February 14, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants