-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tooltip to navList
if the text is truncated
#2610
Conversation
🦋 Changeset detectedLatest commit: 8e61e91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Uh oh! @thesnowrose, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
1 similar comment
Uh oh! @thesnowrose, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
…n_truncation' into nav_list_tooltips_on_truncation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to know what @primer/accessibility-reviewers think of this. I get the sense this would be quite confusing for ATs unless we somehow hide the tooltip for them?
To provide some additional context: I checked the preview with Chrome + NVDA, the full name is announced only once |
…n_truncation' into nav_list_tooltips_on_truncation
…tems respect trucation behavior
Co-authored-by: Cameron Dutro <camertron@gmail.com> Co-authored-by: thesnowrose <thesnowrose@users.noreply.github.com>
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
Currently for the
Primer::Beta::NavList
there is no way to show a tooltip only on text truncation. This PR gives the ability to choose whether or not to add a tooltip based on whether or not the text is truncated, (an ellipsis is present) in the navlist.Screenshots
Before, the tooltip would show regardless if the text was truncated, now we can control when the show it.
Integration
No, this does not break existing production code only a new feature to be added if wanted.
List the issues that this change affects.
Closes: https://github.com/github/actions-build/issues/200
Closes: https://github.com/github/primer/issues/2791
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.