Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change NavList's 'show more' example to be more representative of what we do in prod #2622

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

camertron
Copy link
Contributor

What are you trying to accomplish?

We're currently creating an instance of OpenStruct to render async NavList items, which is not how we do it in prod. This PR updates PVC with a more realistic example.

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Copy link

changeset-bot bot commented Feb 20, 2024

⚠️ No Changeset found

Latest commit: 2eaace0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@camertron camertron added the skip changeset Pull requests that don't change the library output label Feb 20, 2024
@camertron camertron marked this pull request as ready for review February 21, 2024 04:19
@camertron camertron requested review from a team and keithamus and removed request for jonrohan February 21, 2024 04:19
@camertron camertron merged commit 0801db9 into main Feb 27, 2024
28 of 29 checks passed
@camertron camertron deleted the better_show_more_item_example branch February 27, 2024 19:49
jonrohan pushed a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants