-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fix issue where tooltip is only not shown for first item in navlist when not truncated #2729
Conversation
🦋 Changeset detectedLatest commit: cddbc69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for tracking this down! Just a comment about cases where not all list items have tooltips.
…e-tooltip' into thesnowrose/truncate-tooltip
…list when not truncated (#2729) Co-authored-by: thesnowrose <thesnowrose@users.noreply.github.com>
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
This PR does two things.
:ne
so as not to be on top of the next item in the list.Screenshots
The issue before the PR.
Screen.Recording.2024-03-26.at.1.55.03.PM.mov
Integration
List the issues that this change affects.
Closes: https://github.com/github/actions-build/issues/496
Closes: https://github.com/github/actions-build/issues/498
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.