Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix issue where tooltip is only not shown for first item in navlist when not truncated #2729

Merged
merged 7 commits into from
Mar 26, 2024

Conversation

thesnowrose
Copy link
Contributor

@thesnowrose thesnowrose commented Mar 26, 2024

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

This PR does two things.

  1. It sets the direction of the tooltip in the navlist to be :ne so as not to be on top of the next item in the list.
  2. There is currently a bug where only the first item in the navlist works correctly in not showing the tooltip when the text is not truncated. Every other item shows the tooltip when it shouldn't. This was due to the TypeScript only updating the first label.

Screenshots

The issue before the PR.

Screen.Recording.2024-03-26.at.1.55.03.PM.mov

Integration

List the issues that this change affects.

Closes: https://github.com/github/actions-build/issues/496
Closes: https://github.com/github/actions-build/issues/498

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: cddbc69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for tracking this down! Just a comment about cases where not all list items have tooltips.

@camertron camertron merged commit 2b0a7bf into main Mar 26, 2024
31 checks passed
@camertron camertron deleted the thesnowrose/truncate-tooltip branch March 26, 2024 21:25
@primer primer bot mentioned this pull request Mar 26, 2024
jonrohan pushed a commit that referenced this pull request Mar 27, 2024
…list when not truncated (#2729)

Co-authored-by: thesnowrose <thesnowrose@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants