Add a leading spinner to the TextField component #2895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
This PR adds a leading spinner to
Primer::Alpha::TextField
. Currently, the component itself does not make use of the spinner, but the component's auto-check functionality could eventually use it. I decided not to implement such functionality at this time, since my work is currently focused on implementing our newSelectPanel
component in dotcom. The spinner will come in handy over there to indicate a loading state when results are being fetched from the sever.The spinner can be shown via the
showLeadingSpinner()
method in JavaScript, and hidden viahideLeadingSpinner()
.Screenshots
Here's a video showing the text field with a magnifying glass as its leading visual, which is eventually replaced with a spinner, then replaced with the magnifying glass again.
text_field_spinner.mov
Integration
No changes necessary in production.
Risk Assessment
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.