Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab overflow #2904

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Fix tab overflow #2904

merged 6 commits into from
Jun 14, 2024

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Jun 12, 2024

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

This PR removes the scrollbars that appear inside tab container tabs.

Screenshots

A screenshot showing two tabs. The tab on the right has a visible scrollbar.

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Added/updated previews (Lookbook)

  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Jun 12, 2024

🦋 Changeset detected

Latest commit: 345b318

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 12, 2024

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camertron camertron marked this pull request as ready for review June 14, 2024 16:23
@camertron camertron requested review from a team as code owners June 14, 2024 16:23
@camertron camertron requested review from lukasoppermann and langermank and removed request for a team June 14, 2024 16:23
@camertron camertron merged commit 96307bf into main Jun 14, 2024
31 checks passed
@camertron camertron deleted the fix_tab_overflow branch June 14, 2024 16:24
@primer primer bot mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants