Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SelectPanel] Raise an error when remote fetch + hidden filter combo #3053

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

camertron
Copy link
Contributor

What are you trying to accomplish?

This PR raises an error if the filter input is hidden and the fetch strategy is :remote (the default). This is an invalid state the component should actively guard against.

Integration

No updates necessary in production - nobody is using this particular combo of options at the moment.

List the issues that this change affects.

Fixes https://github.com/github/primer/issues/3895

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
    - [ ] Added/updated documentation
  • Added/updated previews (Lookbook)
    - [ ] Tested in Chrome
    - [ ] Tested in Firefox
    - [ ] Tested in Safari
    - [ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: 4553969

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron marked this pull request as ready for review September 5, 2024 17:00
@camertron camertron requested a review from a team as a code owner September 5, 2024 17:00
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@camertron camertron merged commit 871c818 into main Sep 9, 2024
37 checks passed
@camertron camertron deleted the error_when_remote_and_no_filter_input branch September 9, 2024 22:34
@primer primer bot mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants