-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in documentation #3090
Conversation
|
Uh oh! @jasonrclark, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
1 similar comment
Uh oh! @jasonrclark, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! Thanks for fixing it 🙏🏻
@broccolinisoup Glad to help out! I don't have merge rights over here, is that something you'll take care of for me on it? |
@jasonrclark of course! |
What are you trying to accomplish?
Fixing a typo in the comments which I believe is rendered into the website at https://primer.style/view-components/lookbook/pages/system_arguments/
Screenshots
Risk Assessment
Anything you want to highlight for special attention from reviewers?
Just a typo
Accessibility
Merge checklist
Added/updated testsAdded/updated previews (Lookbook)Tested in ChromeTested in FirefoxTested in SafariTested in EdgeTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.