Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SelectPanel] Fix issue causing no error banner to appear when there are no matches #3168

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Oct 22, 2024

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

The SelectPanel component has a bug preventing the error banner from appearing if the previous filter operation produced no results.

Screenshots

Before

before.mov

After

after.mov

Integration

No changes necessary in production.

List the issues that this change affects.

Fixes https://github.com/github/primer/issues/4260

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: b1398c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron marked this pull request as ready for review October 24, 2024 16:34
@camertron camertron requested a review from a team as a code owner October 24, 2024 16:34
@camertron camertron requested review from joshblack and jonrohan and removed request for joshblack October 24, 2024 16:34
@camertron camertron merged commit 82c2b0a into main Oct 28, 2024
36 checks passed
@camertron camertron deleted the fix_select_panel_error_when_no_matches branch October 28, 2024 16:56
@primer primer bot mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants