Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beta layouts #937

Closed
wants to merge 118 commits into from
Closed
Changes from 2 commits
Commits
Show all changes
118 commits
Select commit Hold shift + click to select a range
78e67e7
Add SplitLayout skeleton
jklina Dec 7, 2021
67d0f62
Add SplitLayout
jklina Dec 7, 2021
a3719ce
Add PageLayout skeleton
jklina Dec 7, 2021
e1b3b25
Add wrapper sizes, header, and footer to layout
jklina Dec 7, 2021
deadbb9
Add outer spacing and gaps
jklina Dec 7, 2021
a3b4b5d
add responsive_variant option to layout
jklina Dec 7, 2021
97ea4c2
update documentation
jklina Dec 7, 2021
4c3505f
Add pane options
jklina Dec 7, 2021
684b6f6
update docs, stories for layouts
jklina Dec 7, 2021
5887991
docs: build docs
actions-user Dec 7, 2021
0fdb1c6
sync possible values, test default config
jklina Dec 8, 2021
9aa4a58
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 8, 2021
190c6f5
sync documentation with name changes
jklina Dec 8, 2021
32b5637
further sync documentation to args
jklina Dec 8, 2021
b844378
generate new docs to keep in sync w api
jklina Dec 8, 2021
8151329
docs: build docs
actions-user Dec 8, 2021
3d2ff3f
remove replaced base_layout template
jklina Dec 8, 2021
b972d28
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 8, 2021
26f3f86
remove duplicate test
jklina Dec 8, 2021
1094b7f
test header and footer
jklina Dec 8, 2021
64345e6
remove unused mappings
jklina Dec 8, 2021
3b3331e
test different pane tags
jklina Dec 8, 2021
d195b96
docs: build docs
actions-user Dec 8, 2021
d4d5aa7
remove duplicate tag options
jklina Dec 8, 2021
e44cb9d
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 8, 2021
5fdc2ed
docs: build docs
actions-user Dec 8, 2021
3dfbca5
add space between sections
jklina Dec 8, 2021
60b99a8
test pane tag options on SplitLayout
jklina Dec 8, 2021
42de455
add arg documentation to SplitLayout
jklina Dec 8, 2021
ae24424
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 8, 2021
14675ab
docs: build docs
actions-user Dec 8, 2021
ccb84a0
set status for sub components
jklina Dec 8, 2021
5b9372a
set proper requirements for component testing
jklina Dec 8, 2021
a6d331b
docs: build docs
actions-user Dec 8, 2021
df442e0
add test for main tags
jklina Dec 8, 2021
90c88ac
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 8, 2021
7a8f1ca
fix linting errors
jklina Dec 8, 2021
dd82910
fix erblinter errors
jklina Dec 8, 2021
1f6384a
move pane consts in Pane
jklina Dec 10, 2021
cb132ca
docs: build docs
actions-user Dec 10, 2021
4d741ef
use updated css class name
jklina Dec 10, 2021
609e732
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 10, 2021
e79a67b
use latest CSS classes
jklina Dec 10, 2021
976bb89
update pane positioning to new spec
jklina Dec 10, 2021
dbef809
update header and footer classes
jklina Dec 10, 2021
8205ff2
continue updating class names to new spec
jklina Dec 10, 2021
b595f79
docs: build docs
actions-user Dec 10, 2021
947129f
remove Bookend sub component
jklina Dec 10, 2021
7c2ee7c
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 10, 2021
d644743
docs: build docs
actions-user Dec 10, 2021
ab54155
update css classes for splitlayout
jklina Dec 13, 2021
fe777ec
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 13, 2021
1f2458b
docs: build docs
actions-user Dec 13, 2021
d8e9907
use correct class name
jklina Dec 13, 2021
13f998f
remove unused class name
jklina Dec 13, 2021
3d323ea
docs: build docs
actions-user Dec 13, 2021
e300bcb
update description with latest version
jklina Dec 13, 2021
f9fcabe
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 13, 2021
efa9f7c
docs: build docs
actions-user Dec 13, 2021
c10777a
Merge branch 'main' into add-beta-layouts
jklina Dec 13, 2021
b9dbe7e
appease linter
jklina Dec 13, 2021
c8dd211
remove reference to removed component
jklina Dec 13, 2021
ac7a440
sidebar renamed pane
jklina Dec 13, 2021
a6dfc8f
rename split_layout to split_page_layout
jklina Dec 13, 2021
98e60cc
remove more Sidebar references
jklina Dec 13, 2021
091b29b
docs: build docs
actions-user Dec 13, 2021
e815af4
add additional info about keyboard selection order
jklina Dec 13, 2021
5f2577c
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 13, 2021
87d685a
docs: build docs
actions-user Dec 13, 2021
aa6c7d3
Namespace PageLayout slots
jklina Dec 14, 2021
56c7484
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 14, 2021
7b20e20
Namespace SplitPageLayout slots
jklina Dec 14, 2021
bea0d06
docs: build docs
actions-user Dec 14, 2021
338ae1a
Update stories to use new API
jklina Dec 14, 2021
a7b0480
Use updated API
jklina Dec 14, 2021
1c86a65
Use new slots API
jklina Dec 14, 2021
e52640e
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 14, 2021
f339dd0
Cleaning up documentation for clarity.
jklina Dec 14, 2021
4cf253a
docs: build docs
actions-user Dec 14, 2021
43d5446
Docs cleanup
jklina Dec 14, 2021
89f2fff
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 14, 2021
c131953
docs: build docs
actions-user Dec 14, 2021
2268fa5
cleanup
jklina Dec 14, 2021
a7ef52d
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 14, 2021
96356e4
add argument docs to Pane initializer
jklina Dec 14, 2021
d7262a5
Documentation cleanup
jklina Dec 14, 2021
c88c7da
docs: build docs
actions-user Dec 14, 2021
ebef84d
Convert variant css ref to responsive
jklina Dec 21, 2021
9fe9cc5
Rename `responsive_primary` -> `primary`
jklina Dec 21, 2021
e346e92
`responsive_position` -> `position_narrow`
jklina Dec 21, 2021
3356fc3
`hasDivider` -> `dividerNarrow`
jklina Dec 21, 2021
331ce16
Remove regions reference
jklina Dec 21, 2021
dd505a7
Pane responsive_divider -> divider_narrow
jklina Dec 22, 2021
662b37b
Header responsive_divider -> divider_narrow
jklina Dec 22, 2021
54b9fe2
Footer responsive_divider -> divider_narrow
jklina Dec 22, 2021
633b0cf
Add inherit argument to divider options
jklina Dec 22, 2021
9e67d9a
Cleanup positioning of constants
jklina Dec 22, 2021
f107154
Ensure pane divider classes depend on position
jklina Dec 22, 2021
b63a015
Update pane, header dividers to new spec
jklina Dec 22, 2021
6bba667
Update footer to new spec
jklina Dec 22, 2021
f8669bb
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 22, 2021
37a9e63
docs: build docs
actions-user Dec 22, 2021
d8a8591
Update stories to use new Layout API
jklina Dec 22, 2021
425f26f
Merge branch 'main' into add-beta-layouts
jklina Dec 22, 2021
accb6f1
Use primer css with PageLayout classes
jklina Dec 22, 2021
c2dda83
Appease rubocop
jklina Dec 23, 2021
bc957b8
Fix accidental double backtick
jklina Dec 23, 2021
ac949f7
docs: build docs
actions-user Dec 23, 2021
0b524d8
Remove double backtick
jklina Dec 23, 2021
6d8c2e3
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Dec 23, 2021
d809392
Sync story with API change
jklina Dec 23, 2021
004e1bf
Update CSS classes
jklina Dec 23, 2021
12b012b
docs: build docs
actions-user Dec 23, 2021
966682d
Merge branch 'main' into add-beta-layouts
jonrohan Jan 19, 2022
3503f3f
Merge branch 'main' into add-beta-layouts
jklina Jan 21, 2022
4a6d8f6
Bump primer/css
jklina Jan 21, 2022
0ab7e9e
Merge branch 'add-beta-layouts' of https://github.com/primer/view_com…
jklina Jan 21, 2022
a96404f
Update yarn.lock
jklina Jan 21, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions static/constants.json
Original file line number Diff line number Diff line change
@@ -567,8 +567,7 @@
}
},
"Primer::Dropdown": {
"Menu": "Primer::Dropdown::Menu",
"MenuTest": "Primer::Dropdown::MenuTest"
"Menu": "Primer::Dropdown::Menu"
},
"Primer::Dropdown::Menu": {
"AS_DEFAULT": "default",