-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove blankslate heading styling #969
Conversation
This has caused issues where consumers have used the h4 tag and been confused that the font-size isn't adjusted. The .h2 utility tag adds !important rules which we want to avoid because we can't override them.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/view-components/8eKdMxNtgoW7PMtVkm8Af9g6nLaB |
Question for @ashygee - do we want to maintain the h2 sizing even if a different tag is passed in? I'm guessing that was the original intention but we'll have to add a |
@pouretrebelle no I don't think we should. At the time of the API audit I had made a recommendation that the default would be an |
Superseded by #1000 |
Primer::Beta::Blankslate
forces.h2
styling on the heading slot even if a non-h2 tag is passed in.This was flagged by @rewinfrey on Slack, a lot of confusion was caused by the
h4
tag having a.h2
class, and since.h2
uses!important
declarations it couldn't be overridden.The migration script to beta defaults to a h2 tag, so there are only a handful of examples that specify a different tag; in these instances the font size would be reduced with this change.