Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix optionalOf serialize bug #31 #33

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix optionalOf serialize bug #31 #33

wants to merge 4 commits into from

Conversation

xiangxn
Copy link

@xiangxn xiangxn commented Jul 6, 2020

No description provided.

@fzxu
Copy link
Contributor

fzxu commented Jul 6, 2020

@xiangxn could you format these 2 files?

lib/src/client.dart
lib/src/serialize.dart

@xiangxn
Copy link
Author

xiangxn commented Jul 8, 2020

Is there a format requirement? I remember only adding two lines of code.

@xiangxn
Copy link
Author

xiangxn commented Jul 8, 2020 •
edited
Loading

fbdedf1
There are no unnecessary changes?

@fzxu
Copy link
Contributor

fzxu commented Jul 8, 2020 •
edited
Loading

If you check the CI build, it actually failed: https://github.com/primes-network/eosdart/runs/841856673
because of the format:

$ unformatted=`dartfmt -n .`

Files are unformatted:

lib/src/client.dart

lib/src/serialize.dart

@fzxu
Copy link
Contributor

fzxu commented Jul 22, 2020

@xiangxn could you take are of above?

@fzxu
Copy link
Contributor

fzxu commented Sep 17, 2020

@xiangxn looks like the build is failing still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiangxn @fzxu