Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(G3M) Swap fee expressed in WAD #106

Merged
merged 5 commits into from
Nov 3, 2023
Merged

(G3M) Swap fee expressed in WAD #106

merged 5 commits into from
Nov 3, 2023

Conversation

clemlak
Copy link
Contributor

@clemlak clemlak commented Nov 2, 2023

Allows the swap fee in G3M to be expressed in WAD (instead of beep) (cf #100).

(Not sure if we want to merge this to main)

@clemlak clemlak self-assigned this Nov 2, 2023
@clemlak clemlak linked an issue Nov 2, 2023 that may be closed by this pull request
@clemlak clemlak changed the title feat: update IG3M interface (G3M) Swap fee expressed in WAD Nov 3, 2023
@0xJepsen 0xJepsen marked this pull request as ready for review November 3, 2023 14:57
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xJepsen 0xJepsen self-requested a review November 3, 2023 15:06
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on changes in #108

@clemlak
Copy link
Contributor Author

clemlak commented Nov 3, 2023

Misunderstanding on my side, it's fixed now!

@kinrezC kinrezC merged commit bc7fa43 into main Nov 3, 2023
@kinrezC kinrezC deleted the feat/g3m-swap-fee-wad branch November 3, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(RMM): Allow for fee parameter to be given in WAD value.
4 participants