Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/live tx #107

Merged
merged 13 commits into from
Nov 4, 2023
Merged

Feat/live tx #107

merged 13 commits into from
Nov 4, 2023

Conversation

Alexangelj
Copy link
Contributor

@Alexangelj Alexangelj commented Nov 2, 2023

There is some jank in here!

  • Messages are "piped" to the top of the Application to leverage Command.
  • Screens are rendered individually and drop all of their "memory" when a screen changes
  • Components can manage their own state, view, and interaction with external environments (arbiter, json rpc, etc.), but the message piping can be a little complicated
  • General Error and Debug messages for Application don't do anything right now, but they will probably be helpful!
  • Don't know how to do testing yet, but I feel like that will be very important
  • Need to add more features to just test stuff in general

And cargo fmt is formatting the bindings...

Upgrading + fixing some failing ci, upgrades thanks to: https://www.reillywood.com/blog/rust-faster-ci/
https://github.com/nushell/nushell/blob/07893e01c15e7b4598141fb6d3876d5632b7ae0a/.github/workflows/ci.yml#L3-L5

Ci upgrades:

  • clippy 4m -> 2m
  • build 7m -> 5m
  • test 11m (was building, 7m to build 4m to test) -> 8m

We will see how much time we gain later with the cache now too

@Alexangelj Alexangelj marked this pull request as ready for review November 3, 2023 15:09
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good

@Alexangelj Alexangelj merged commit d74471f into main Nov 4, 2023
@Alexangelj Alexangelj deleted the feat/live-tx branch November 4, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants