Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/sync sim contract versions #114

Merged
merged 5 commits into from
Nov 5, 2023
Merged

Fix/sync sim contract versions #114

merged 5 commits into from
Nov 5, 2023

Conversation

Alexangelj
Copy link
Contributor

@Alexangelj Alexangelj commented Nov 4, 2023 •
edited
Loading

Aligns current version of smart contracts with current version of sim, notes:

IMPORTANT

  • Fees are not supported. Fees were being set but the arbitrageur's math does not include fees, leading to "InvalidSwap" errors (invariant not growing enough).
  • Decoding errors with the wrong error method leads to sim panics, was occurring in arbitrageur.rs.
  • Contracts are in a rough state, some functions are not used now. We can do some cleanup.

@Alexangelj Alexangelj marked this pull request as ready for review November 5, 2023 16:38
Alexangelj
Alexangelj commented Nov 5, 2023
View reviewed changes
Copy link
Contributor Author

@Alexangelj Alexangelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Alexangelj Alexangelj merged commit 3094bc7 into main Nov 5, 2023
@Alexangelj Alexangelj deleted the fix/sync-sim-contract-versions branch November 5, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Alexangelj