Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dca/swapper agent #152

Merged
merged 13 commits into from
Nov 14, 2023
Merged

Dca/swapper agent #152

merged 13 commits into from
Nov 14, 2023

Conversation

Autoparallel
Copy link
Contributor

@Autoparallel Autoparallel commented Nov 13, 2023 •
edited
Loading

Autoparallel
Autoparallel commented Nov 13, 2023
View reviewed changes
simulation/src/agents/mod.rs
use std::marker::{Send, Sync};

pub struct Agents(pub Vec<Box<dyn Agent>>);
#[derive(Debug)]
pub struct Agents(pub LinkedHashMap<String, Box<dyn Agent>>);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alexangelj

@Autoparallel Autoparallel marked this pull request as ready for review November 14, 2023 15:49
@0xJepsen 0xJepsen requested review from Alexangelj, 0xJepsen and kinrezC and removed request for Alexangelj, 0xJepsen and kinrezC November 14, 2023 15:50
0xJepsen
0xJepsen approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xJepsen 0xJepsen merged commit f324504 into main Nov 14, 2023
@0xJepsen 0xJepsen deleted the dca/swapper-agent branch November 14, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexangelj Alexangelj Alexangelj approved these changes

@0xJepsen 0xJepsen 0xJepsen approved these changes

@kinrezC kinrezC Awaiting requested review from kinrezC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Autoparallel @Alexangelj @0xJepsen