ledger support. #204
Merged
ledger support. #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
0xJepsen
force-pushed
the
ledger/integration
branch
from
42e88bd to
1ebc85f
Compare
Alexangelj
approved these changes
Dec 1, 2023
|
Build failed can we try to fix that? |
remove unused deps code-spell final changes recieving signed signatures 😎 verify we get response propagate up to application progress on api New approach current abstraction ledger support. I put documentation in the comments regarding APDU embedded device commands as well as a link to the ethereum ledger application ADPU instructions
0xJepsen
force-pushed
the
ledger/integration
branch
from
1fa4968 to
cc203b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put documentation in the comments regarding APDU edded device commands as well as a link to the ethereum ledger application ADPU instructions.
This should expose the rust api of the ledger with
new_ledgerandsign_tx, If needed i can add more functionality to the to expose more of the ethereum ledger app or tbh and APDU device communication. @Alexangelj Maybe you have a ledger and can test this? Mine gets in on thursday.