Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/v0.2.0 #214

Merged
merged 38 commits into from
Dec 12, 2023
Merged

UI/v0.2.0 #214

merged 38 commits into from
Dec 12, 2023

Conversation

Alexangelj
Copy link
Contributor

@Alexangelj Alexangelj commented Dec 11, 2023 •
edited
Loading

another banger

major features

  • Interactive charts
  • UI component system
  • Portfolio dashboard comprehensive data model
  • Portfolio dashboard comprehensive view model
  • Signer/provider/middleware abstraction "Cortex", to replace all individual clients as a trait that the clients can implement (ledger, arbiter/revm, anvil local, etc.)
  • Upgrades to dashboard layout
  • Integrated components together so the dashboard is alive!
  • Settings page w/ rpc list saved to local profile

minor features

  • ui component system rework reduced sloc
  • Complexity in data reduced significantly with the introduction of the data model
  • Loading screen is clean but slow right now
  • Interactive chart features have all the important features we need (drag, scroll, resize, realtime, labels, hovering points, etc.)
  • middleware type added as a generic to protocol client (temp)
  • changed some of the variable names in atomic arb contract
  • added init event to dfmm
  • accidentally cargo fmtd bindings (ignore was missing), so added ignore

@Alexangelj
refactor(screens): moves old screens, setting up screens for 0.2.0
a97d578
@Alexangelj
rpc management in settings
e888f47
@Alexangelj
refactor(load): adds a dev client that deploys protocol
4b915af
@Alexangelj
anvil snapshot and balance loading
b762c22
@Alexangelj
executing init in dfmm from app
8eeeb86
@Alexangelj
styling for portfolio dashboard
ecc9529
@Alexangelj
feat(fetch-balances): gets position balances from chain
e61af00
@Alexangelj
chore(remove-bindings): unused bindings removed from clients crate
f2cfcb7
@Alexangelj
loading screen
7677fc3
@Alexangelj
initial chart component
d618768
@Alexangelj
chart mvp
e668227
@Alexangelj
very nice labels for current coords in chart
b621eee
@Alexangelj
interactive chart with labels and a new skin
d32c6bf
@Alexangelj
new component system
12498d8
@Alexangelj
docs(ui): adds screenshot for ui components
992b155
@Alexangelj
rough table, made enough progress to know what we need
9b7546a
@Alexangelj
refactor(great-filter): remove all unused components and made contain…
06d3e2d 
…er builder
@Alexangelj
refactor(container): remove container in favor of excalibur container
8a0d392
@Alexangelj
dfmm arb tests
258c6f2
@Alexangelj
refactor(buttons): makes excalibur button wrapper for custom style
a16c1fa
@Alexangelj
docs(components): adds some docstrings to component files
a3cc0b0
@Alexangelj
remove unused window layout in view
e5896fb
@Alexangelj
labeled data values
a475431
@Alexangelj
rough layout in place for dashboard
7f67211
@Alexangelj
dashboard layout and add ignore bindings to rust fmt toml
dabc68d
@Alexangelj
an excellent chart api has been created
8f4d9bd
@Alexangelj
full featured interactive chart is live!
e4454c3
@Alexangelj
got a sort of complicated trait made for middleware but it will work!
76e7bac
@Alexangelj
poc of data model fetcher with alloy sol types
c2f9322
@Alexangelj
a working data model for portfolio dashboard
90143ea
@Alexangelj Alexangelj marked this pull request as ready for review December 11, 2023 20:12
0xJepsen
0xJepsen approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alex you're really cooking here. I like the design refactor and charts a ton. Also the builders are really helpful.

@Alexangelj
Copy link
Contributor Author

Alex you're really cooking here. I like the design refactor and charts a ton. Also the builders are really helpful.

awesome. what do you think about that cortex trait? I think it'd be better if there was one "thing" that manages our provider/signer connections/middleware, so I tried to encapsulate it there.

@0xJepsen
Copy link
Contributor

Alex you're really cooking here. I like the design refactor and charts a ton. Also the builders are really helpful.

awesome. what do you think about that cortex trait? I think it'd be better if there was one "thing" that manages our provider/signer connections/middleware, so I tried to encapsulate it there.

Yeah i saw this, i think it's a great way to manage the interactions between the front end and eth-core infrastructure as long as it can be generic over the right traits i am bullish on this. It also contextualizes the devX of the eth infra nicely.

@0xJepsen 0xJepsen merged commit cc2a1a2 into main Dec 12, 2023
6 of 9 checks passed
@0xJepsen 0xJepsen deleted the ui/v0.2.0 branch December 12, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xJepsen 0xJepsen 0xJepsen approved these changes

@kinrezC kinrezC kinrezC approved these changes

@Autoparallel Autoparallel Awaiting requested review from Autoparallel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexangelj @0xJepsen @kinrezC