Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy.rs for contract deployments #24

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Deploy.rs for contract deployments #24

merged 6 commits into from
Oct 10, 2023

Conversation

kinrezC
Copy link
Contributor

@kinrezC kinrezC commented Oct 5, 2023

No description provided.

Alexangelj
Alexangelj approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@Alexangelj Alexangelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ez

0xJepsen
0xJepsen approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clemlak
Copy link
Contributor

clemlak commented Oct 6, 2023

Got Error: Invalid data when I tried to run this?

clemlak
clemlak suggested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@clemlak clemlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that some constructor parameters are not using the right types (see comments), causing the invalid data error.

box-simulation/src/setup/deploy.rs Outdated Show resolved Hide resolved
box-simulation/src/setup/deploy.rs Outdated Show resolved Hide resolved
box-simulation/src/setup/deploy.rs Outdated Show resolved Hide resolved
Autoparallel
Autoparallel reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we not find the #[derive(Deploy)] macro useful?

@kinrezC
Copy link
Contributor Author

kinrezC commented Oct 10, 2023

Did we not find the #[derive(Deploy)] macro useful?

done

Alexangelj
Alexangelj approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@Alexangelj Alexangelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a nice pr

@Alexangelj Alexangelj removed the request for review from zachdt October 10, 2023 15:22
@kinrezC kinrezC merged commit ca413d5 into main Oct 10, 2023
@Alexangelj Alexangelj deleted the feat/deployments branch October 10, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Autoparallel Autoparallel Autoparallel left review comments

@clemlak clemlak clemlak requested changes

@Alexangelj Alexangelj Alexangelj approved these changes

@0xJepsen 0xJepsen 0xJepsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kinrezC @clemlak @Autoparallel @Alexangelj @0xJepsen