Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/multi strategy dfmm poc #277

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Feat/multi strategy dfmm poc #277

merged 3 commits into from
Jan 5, 2024

Conversation

kinrezC
Copy link
Contributor

@kinrezC kinrezC commented Jan 5, 2024

Depends on #276. Review + merge #276 before reviewing this so as to reduce the diff with main.

@kinrezC kinrezC requested review from Alexangelj and clemlak January 5, 2024 22:53
Copy link
Contributor

@Alexangelj Alexangelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking very good, maybe we make WeightX, Tau, Strike structs all one type?

@kinrezC kinrezC marked this pull request as ready for review January 5, 2024 23:50
@kinrezC
Copy link
Contributor Author

kinrezC commented Jan 5, 2024

looking very good, maybe we make WeightX, Tau, Strike structs all one type?

love this idea, good shout

@kinrezC kinrezC force-pushed the feat/multi-strategy-dfmm-poc branch from 8ddce7d to a090e89 Compare January 5, 2024 23:54
@kinrezC kinrezC merged commit 1348841 into main Jan 5, 2024
5 checks passed
@clemlak clemlak deleted the feat/multi-strategy-dfmm-poc branch January 23, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants