Feat/arbiter provider #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xJepsen
reviewed
Jan 9, 2024
| &mut self, | ||
| client: Arc<M>, | ||
| ) -> anyhow::Result<()> { | ||
| let chain_id = client.get_chainid().await?; |
There was a problem hiding this comment.
What is the arbiter Chain Id? We might have it set to 1 right now which will cause collisions with main-net here. We should double check and if it is 1 we should change it so this doesn't happen. What chain Id does anvil support?
|
Overall i think this approach is really good. We should be careful about what chain ID is used in simulations. We can certainly configure it to what we want but i don't think we configure it at all right now, I'm sure it would be a quick fix in arbiter though. |
0xJepsen
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currentfield to the model for the currently connected network chain id.connect_to_networkto the model, for setting thecurrentfield based on the chain_id of the client in the argument.portfoliofield to benetworks, which is a hashmap of chain ids to their respective data models.Closes #229