Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger User flow #283

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Ledger User flow #283

merged 6 commits into from
Jan 19, 2024

Conversation

0xJepsen
Copy link
Contributor

@0xJepsen 0xJepsen commented Jan 9, 2024

@Alexangelj could you review and show me how to update the root component here? The button makes a successful call to the ledger (if you have one to test, if not i can screen share). The thing i struggle with here is how to then given the api response, how do we re-update the view to reflect the changes.

will Close #264

@0xJepsen 0xJepsen requested a review from Alexangelj January 9, 2024 15:10
@0xJepsen 0xJepsen changed the title I am confused about our child <-> parent communication here. Ledger User flow Jan 11, 2024
@0xJepsen 0xJepsen requested a review from zachdt January 11, 2024 22:53
@0xJepsen 0xJepsen marked this pull request as ready for review January 11, 2024 22:54
Copy link
Contributor

@Alexangelj Alexangelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking forward to trying this out

@0xJepsen 0xJepsen merged commit 2d80cb8 into main Jan 19, 2024
5 checks passed
@0xJepsen 0xJepsen deleted the ledger_userflow branch January 19, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings: Ledger Button
2 participants