Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added default rpc #296

Merged
merged 2 commits into from
Feb 7, 2024
Merged

added default rpc #296

merged 2 commits into from
Feb 7, 2024

Conversation

0xJepsen
Copy link
Contributor

@0xJepsen 0xJepsen commented Jan 16, 2024 •
edited
Loading

Closes #263

Strange behavior:

  • When adding a new RPC, the view of the rpc table overwrites the first rpc.
  • Right now this is the default main-net RPC

The desired behavior would be that when an RPC is added, the new rpc doesn't overwrite the view but is just appended to the view.

Also when we delete any rpc (one or many) the view completely empties when it should maintain rpcs that aren't deleted.

@0xJepsen 0xJepsen marked this pull request as ready for review January 22, 2024 20:08
@0xJepsen 0xJepsen requested a review from Alexangelj February 7, 2024 23:05
@0xJepsen 0xJepsen merged commit 79564f2 into main Feb 7, 2024
5 checks passed
@0xJepsen 0xJepsen deleted the settings_rpc branch February 7, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexangelj Alexangelj Awaiting requested review from Alexangelj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings: Provide a default main-net rpc
1 participant
@0xJepsen