Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone factory & various fixes #318

Merged
merged 24 commits into from
Jan 24, 2024
Merged

Clone factory & various fixes #318

merged 24 commits into from
Jan 24, 2024

Conversation

clemlak
Copy link
Contributor

@clemlak clemlak commented Jan 24, 2024

Closes:

Also worth mentioning:

  • Token X and Y are now included in the init event
  • Pool struct doesn't include the inited field anymore
  • _manageTokens in DFMM contract is now internal

clemlak added 23 commits January 23, 2024 12:47
@clemlak
feat: add initialize to LPToken contract
97b64f0
@clemlak
feat: add clone function to DFMM, use it in init
06dced9
@clemlak
test: add DFMMConstructorTest tests
539eaa1
@clemlak
feat: remove name and symbol for LPToken implementation
ecb0fae
@clemlak
test: check LPToken implementation metadata
40bebd9
@clemlak
feat: change _manageTokens visibility to internal
a2a07c5
@clemlak
feat: improve rounding in favor of DFMM (when burning / minting)
73a8d82
@clemlak
feat: remove unused clone function
db9767b
@clemlak
feat: move cloning error to IDFMM
3b625bd
@clemlak
feat: add updateController
447ac70
@clemlak
test: cannot allocate to not initialized pool
1a0a3f3
@clemlak
test: cannot allocate when no pools were initialized
1aac837
@clemlak
feat: remove inited from Pool struct, initialized modifier
50520ed
@clemlak
chore: add NatSpec to pools, lpTokenImplementation
1f2f7e3
@clemlak
feat: add tokenX / tokenY to Init event
23bae25
@clemlak
test: check LP token clone deployment on init
0620243
@clemlak
test: remove unused imports in Init test file
33def3b
@clemlak
test: add updateController tests
ae84d8b
@clemlak
test: add getPoolController utils function
37c83b6
@clemlak
chore: move computePrice to G3MExtendedLib
8003dd5
@clemlak
feat: move reserves condition check in _settle to revert early
294acf8
@clemlak
test: add pool liquidity token getter util function
00d89c4
@clemlak
chore: add a warning to liquidityOf
7950c08
@clemlak clemlak added the contracts Requiring smart contract changes label Jan 24, 2024
@clemlak clemlak added this to the DFMM going public milestone Jan 24, 2024
@clemlak clemlak self-assigned this Jan 24, 2024
This was linked to issues Jan 24, 2024
Transferable pool controller rights #298
Closed
Add natspec to let developers know NEVER to use this inside a non-view smart contract call #310
Closed
@clemlak clemlak changed the title Contracts/clone factory Clone factory & various fixes Jan 24, 2024
@clemlak clemlak linked an issue Jan 24, 2024 that may be closed by this pull request
Move the amount computation in the isAllocate if else branch and handle the rounding direction #311
Closed
@kinrezC kinrezC merged commit 0577469 into main Jan 24, 2024
5 checks passed
@clemlak clemlak linked an issue Jan 24, 2024 that may be closed by this pull request
Clone factory for LP tokens #303
Closed
@kinrezC kinrezC deleted the contracts/clone-factory branch January 24, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinrezC kinrezC kinrezC approved these changes

@Autoparallel Autoparallel Awaiting requested review from Autoparallel

@Alexangelj Alexangelj Awaiting requested review from Alexangelj

@0xJepsen 0xJepsen Awaiting requested review from 0xJepsen

Assignees

@clemlak clemlak

Labels
contracts Requiring smart contract changes
Projects
None yet
Milestone
DFMM going public
2 participants
@clemlak @kinrezC