Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feats/cli refactor cleanup #35

Merged
merged 8 commits into from
Oct 13, 2023
Merged

Feats/cli refactor cleanup #35

merged 8 commits into from
Oct 13, 2023

Conversation

Autoparallel
Copy link
Contributor

@Autoparallel Autoparallel commented Oct 12, 2023 •
edited
Loading

@Autoparallel Autoparallel marked this pull request as ready for review October 12, 2023 22:16
0xJepsen
0xJepsen suggested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very clean. Can we remove the box-simulation directory all together now? Since it's all just empty?

@Autoparallel
Copy link
Contributor Author

this is very clean. Can we remove the box-simulation directory all together now? Since it's all just empty?

I don't have it locally.

@0xJepsen 0xJepsen self-requested a review October 12, 2023 23:12
0xJepsen
0xJepsen approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm this is nice

@Autoparallel
Delete weight
db95d4a 
not needed. not even sure what this was
Alexangelj
Alexangelj approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Alexangelj Alexangelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much cleaner, nice work

@kinrezC kinrezC merged commit af0134f into main Oct 13, 2023
@Alexangelj Alexangelj deleted the feats/cli-refactor-cleanup branch October 16, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinrezC kinrezC kinrezC approved these changes

@Alexangelj Alexangelj Alexangelj approved these changes

@0xJepsen 0xJepsen 0xJepsen approved these changes

@zachdt zachdt Awaiting requested review from zachdt

@pranavpatilsce pranavpatilsce Awaiting requested review from pranavpatilsce

@clemlak clemlak Awaiting requested review from clemlak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generalize price changer Binary to run sim / cli Configuration
4 participants
@Autoparallel @kinrezC @Alexangelj @0xJepsen